Skip to content

[benchmarker] Prevent crash when 503 response - #1780

Closed
barroco wants to merge 1 commit into
interuss:mainfrom
Orbitalize:benchmarker-error-catch
Closed

barroco wants to merge 1 commit into
interuss:mainfrom
Orbitalize:benchmarker-error-catch

Conversation

@barroco

@barroco barroco commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

When an empty response is returned to the benchmarker, for instance a 503, the benchmarker crashes. This PR fixes this.

@barroco barroco changed the title [benchmarker] Prevent crash when 503 [benchmarker] Prevent crash when 503 response Oct 7, 2026
@barroco
barroco marked this pull request as ready for review October 7, 2026 12:53

@mickmis mickmis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with #1774 this fix should not be required (failure would return None).

@barroco

barroco commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor Author

Ok closing in favour of #1774 .

@barroco barroco closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants