Repository navigation
[evict] Remove locality filter on rid evictions - #1745
Merged
Merged
Conversation
MariemBaccari
force-pushed
the
evict_custom_locality
branch
from
October 6, 2026 07:37
453998b to
d94a4a9
Compare
MariemBaccari
marked this pull request as ready for review
October 6, 2026 07:37
Contributor
|
I am realizing with this PR that for SCD we do not have any filter for locality. I am wondering whether that is actually required for RID to have one? If not it might be even better to just remove that possibility from there... Let's discuss it at the weekly today. |
MariemBaccari
force-pushed
the
evict_custom_locality
branch
from
October 6, 2026 15:47
d94a4a9 to
3d354b9
Compare
MariemBaccari
changed the title
MariemBaccari
force-pushed
the
evict_custom_locality
branch
from
October 6, 2026 15:49
3d354b9 to
4096b9f
Compare
Contributor
Author
|
@mickmis following the discussion at the contributors' meeting, I pushed the changes to remove the filter entirely and marked the locality flag as deprecated. |
mickmis
approved these changes
Oct 7, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo one thing: please add note in 'important information' of next release notes regarding this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the #1717 fix and a follow-up to #1744.
It removes the locality filter on rid evictions.