Repository navigation
[evict] Optimize performance by deleting expired entities in single statements and remove the listing limits - #1725
Merged
Conversation
MariemBaccari
force-pushed
the
evict_performance
branch
5 times, most recently
from
September 24, 2026 11:56
3939454 to
9af0c2b
Compare
MariemBaccari
marked this pull request as ready for review
September 24, 2026 12:33
MariemBaccari
force-pushed
the
evict_performance
branch
7 times, most recently
from
October 5, 2026 08:23
e648fd4 to
9d93af1
Compare
mickmis
approved these changes
Oct 5, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo minor comments.
In addition: could you be more specific in the PR title about the impact this PR has? e.g. mention the ListExpiredX has no limit anymore.
MariemBaccari
changed the title
MariemBaccari
force-pushed
the
evict_performance
branch
from
October 5, 2026 13:53
9d93af1 to
a04fc8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1717.
evict --deleteused to list expired entities then delete them one row at a time inside a shared transaction which, for large backlogs, was the source of contention and performance issues.This PR aims to fix this by:
DeleteExpired*methods on the ISA and SCD repo to delete expired entities in a single statement.The PR also removes the limit in listing expired entities as atomicity is not guaranteed anymore. A follow-up PR ([evict] Add limit flags #1743) will implement a limit feature for deletion.