Skip to content

[raftstore] Make HandleClientRequest generic over its result type - #1716

Merged
mickmis merged 1 commit into
interuss:masterfrom
Orbitalize:raft_generic_handle_client_request
Sep 24, 2026
Merged

mickmis merged 1 commit into
interuss:masterfrom
Orbitalize:raft_generic_handle_client_request

Conversation

@MariemBaccari

@MariemBaccari MariemBaccari commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Following the upgrade to go (#1698) and feedback under #1670, this PR makes the HandleClientRequest generic over its result type.

Implements #1700

@MariemBaccari
MariemBaccari force-pushed the raft_generic_handle_client_request branch 9 times, most recently from b6efe86 to 95fb64c Compare September 21, 2026 23:24
@MariemBaccari
MariemBaccari marked this pull request as ready for review September 21, 2026 23:24

@mickmis mickmis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mickmis

mickmis commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

You might want to implement in this PR the suggestion I made here (if it makes indeed sense): #1672 (comment)
Up to you.

@MariemBaccari

Copy link
Copy Markdown
Contributor Author

@mickmis I replied in #1672 directly :) I suggest to park the suggestion until the gate 1 investigations are done.

@MariemBaccari
MariemBaccari force-pushed the raft_generic_handle_client_request branch from 95fb64c to a1393d1 Compare September 23, 2026 00:09
@MariemBaccari
MariemBaccari force-pushed the raft_generic_handle_client_request branch from a1393d1 to 04bc2be Compare September 23, 2026 14:37
@mickmis
mickmis merged commit 1ef7d93 into interuss:master Sep 24, 2026
18 checks passed
@mickmis
mickmis deleted the raft_generic_handle_client_request branch September 24, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants