Repository navigation
Pending operations: notification log, resend and filter (registrar_center2#237) - #2981
Merged
Merged
Conversation
…ing (registrar_center2#237) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…er2#237) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…#237) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
OlegPhenomenon
marked this pull request as ready for review
November 5, 2026 12:35
Contributor
🚀 Deploy Complete!
(Environment ready for testing) |
1 similar comment
Contributor
🚀 Deploy Complete!
(Environment ready for testing) |
…r_center2#237) The log row was written inside the mailer before delivery, so a failed delivery was logged as sent and every job retry added another row. Log from an ActionMailer observer instead.
Contributor
🚀 Deploy Complete!
(Environment ready for testing) |
maricavor
approved these changes
Nov 12, 2026
Contributor
🚀 Deploy Complete!
(Environment ready for testing) |
3 similar comments
Contributor
🚀 Deploy Complete!
(Environment ready for testing) |
Contributor
🚀 Deploy Complete!
(Environment ready for testing) |
Contributor
🚀 Deploy Complete!
(Environment ready for testing) |
…nding (registrar_center2#237) - Confirmation and notice emails are sent a minute after the request; a change cancelled, confirmed or rejected in that minute no longer triggers a confirmation request with a dead link. - Pending notification test runs the delayed jobs after the request, as Sidekiq does.
Contributor
🚀 Deploy Complete!
(Environment ready for testing) |
maricavor
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend for internetee/registrar_center2#237
domain_pending_notifications: the registrant change confirmation, new registrant notice and delete confirmation emails are logged with time and recipient addresses, only after successful delivery (Observers::PendingNotificationObserver,X-Pending-Notificationheader).GET /repp/v1/domains/:namereturnspending: { requested_at, notifications }(sponsoring registrar only, only while a registrant confirmation is awaited).POST /repp/v1/domains/:name/pending_notificationresends the confirmation email.q[with_pending_operation]=1in the domain list (pendingUpdate / pendingDeleteConfirmation / pendingDelete).repp-apidocis not updated.Tested on staging (registry1-dev with registrar1-dev and registrant1-dev): delayed emails logged after delivery, resend, delete confirmation, confirmation via the emailed link, cancel within the first minute.