Investigate issue 127 - #132
Closed
Hemenguelbindi wants to merge 1 commit into
Closed
Conversation
apconole
reviewed
Aug 13, 2026
Contributor
|
This needs some work. Please don't have a PR where you introduce a problem and then fix it up with a separate commit. Each change should look clean on its own. |
Hemenguelbindi
force-pushed
the
investigate-issue-127
branch
from
August 14, 2026 12:37
43e549e to
d45765d
Compare
Contributor
|
what I mean was - you should squash your fixes together, not that you should keep around stray spacing changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEFORE
issue reproduction
→ ASan heap-use-after-free
→ ieee8023_rchange frees tlv
→ ieee8021qaz_rchange reads freed tlv
AFTER
same reproduction
→ no ASan UAF
→ ieee8023 returns TLV_OK
→ rxProcessFrame stops dispatch
→ application continues working
→ make check passes