Skip to content

feat/wsl2 - #255

Open
rishika-y-gaur wants to merge 8 commits into
intel-retail:mainfrom
rishika-y-gaur:feat/metrics
Open

rishika-y-gaur wants to merge 8 commits into
intel-retail:mainfrom
rishika-y-gaur:feat/metrics

Conversation

@rishika-y-gaur

@rishika-y-gaur rishika-y-gaur commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

added windows collector for pcm, gpu, memory bandwidth

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/performance-tools/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Adds Windows-host telemetry collection for WSL2 benchmarks and integrates GPU, power, memory, and PCM metrics into consolidated results.
Adds Windows telemetry collection and lifecycle management.
Integrates collection with Docker Compose benchmark runs.
Adds WSL2 consolidation logic and tests.

Task this PR will close

close: #340, #341, #342

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

Test all workloads on Windows using WSL2 and Native Linux
For now WSL2 supports CPU and GPU workloads

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/performance-tools )

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Resolve the NPU metric reporting defect and prevent telemetry data loss between iterations.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Adds Windows-host telemetry collection for WSL2 benchmarks and integrates GPU, power, memory, and PCM metrics into consolidated results.

Changes:

  • Adds Windows telemetry collection and lifecycle management.
  • Integrates collection with Docker Compose benchmark runs.
  • Adds WSL2 consolidation logic and tests.
File Description
benchmark-scripts/​windows_metrics.py Implements Windows telemetry collection.
benchmark-scripts/​consolidate_multiple_run_of_metrics.py Merges Windows metrics into summaries.
benchmark-scripts/​benchmark.py Integrates collector lifecycle with Compose.
benchmark-scripts/​benchmark_test.py Tests collection and lifecycle behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread benchmark-scripts/consolidate_multiple_run_of_metrics.py Outdated
@rishika-y-gaur rishika-y-gaur changed the title Feat/metrics [DO NOT MERGE] Feat/wsl2 [DO NOT MERGE] Sep 24, 2026
@rishika-y-gaur rishika-y-gaur changed the title Feat/wsl2 [DO NOT MERGE] feat/wsl2 [DO NOT MERGE] Sep 24, 2026
@rishika-y-gaur rishika-y-gaur changed the title feat/wsl2 [DO NOT MERGE] feat/wsl2 Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved telemetry defects affect PCM and GPU metrics.

1 open finding
1 resolved since last review

🧠 Review effort: Lite


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread benchmark-scripts/windows_metrics.py Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

PCM header handling can omit bandwidth metrics, and GPU averaging excludes idle intervals.

3 open findings

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread benchmark-scripts/windows_metrics.py
Comment thread benchmark-scripts/windows_metrics.py
Signed-off-by: rishika-y-gaur <rishika.gaur@intel.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants