Skip to content

✨ refactor(http): finish accepted requests and headers before drain - #7

Merged
abmmhasan merged 2 commits into
mainfrom
feature/recycling-reset
Oct 4, 2026
Merged

abmmhasan merged 2 commits into
mainfrom
feature/recycling-reset

Conversation

@abmmhasan

@abmmhasan abmmhasan commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Refactor native HTTP workers and protocol attachments to finish pending request admissions before initiating application drain ♻️
  • Update HTTP/1.1, HTTP/2, and HTTP/3 connection handlers to track uncompleted initial exchanges and header blocks 🎨
  • Add tests covering request recycling and incomplete headers during draining across HTTP versions ✅
  • Update workflow configurations to support release tags and condition checks 👷
  • Document graceful sequence and protocol draining behavior during application shutdown 📝

Change

Type

  • Bug fix
  • New feature
  • Refactor
  • Performance
  • Security or reliability
  • Documentation or examples
  • Dependency, CI or tooling
  • Other

Behavior and Compatibility

  • No observable behavior changed
  • Existing behavior was corrected
  • New behavior was introduced
  • Public API or documented behavior changed
  • Backward compatibility may be affected
  • PHP, extension, platform or dependency requirements changed

Validation

  • composer ic:ci
Focused validation
  • composer ic:test:syntax
  • composer ic:test:code
  • composer ic:test:lint
  • composer ic:test:sniff
  • composer ic:test:duplicates
  • composer ic:test:probe
  • composer ic:test:comments
  • composer ic:test:architecture
  • composer ic:test:static
  • composer ic:test:security
  • composer ic:test:refactor

Performance

  • Relevant benchmarks were added or updated
  • Results were compared against a relevant baseline
  • composer ic:benchmark
  • composer ic:bench:quick
  • composer ic:bench:chart

Implementation Notes

Review Focus

Checklist

  • The change is focused and excludes unrelated modifications.
  • Tests cover new, corrected and regression-prone behavior.
  • Public API and backward-compatibility implications were considered.
  • Documentation, examples and type information were updated where required.
  • Performance claims are supported by reproducible benchmarks.
  • No credentials, secrets, personal data or sensitive debug output are included.
  • I followed CONTRIBUTING.md and the engineering principles.

- Refactor native HTTP workers and protocol attachments to finish pending request admissions before initiating application drain ♻️
- Update HTTP/1.1, HTTP/2, and HTTP/3 connection handlers to track uncompleted initial exchanges and header blocks 🎨
- Add tests covering request recycling and incomplete headers during draining across HTTP versions ✅
- Update workflow configurations to support release tags and condition checks 👷
- Document graceful sequence and protocol draining behavior during application shutdown 📝
@abmmhasan
abmmhasan merged commit 745b1c2 into main Oct 4, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant