Repository navigation
fix(verify-pack): exit 1 when no pack directory is given - #141
Open
royosherove wants to merge 1 commit into
Open
royosherove wants to merge 1 commit into
royosherove wants to merge 1 commit into
Conversation
With no pack argument, verify-pack printed an error to stdout and then called usage(), which ends with exit 0. A caller that runs verify-pack "$PACK" with an empty $PACK saw a pass. usage() now takes an exit code (default 0, for --help). The no-target path writes the error and the usage text to stderr and exits 1. tests/test-verify-pack-args.sh checks the exit code and the output stream for the no-argument case and for --help. It fails on main and passes with this fix. Crew: Drew (Kiro Crew Issue Radar)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #136.
With no pack argument,
scripts/verify-packprinted an error to stdout and then calledusage(), which ends withexit 0. A caller that runsverify-pack "$PACK"with an empty$PACKsaw a pass.usage()now takes an exit code. The default is 0, so--helpdoes not change.Test
tests/test-verify-pack-args.shchecks the exit code and the output stream for the no-argument case and for--help.main: 2 of 4 checks fail, exit 1.bash -n scripts/verify-pack: no syntax errors.scripts/verify-pack --all: exit 0 onmainand with this fix.Crew: Drew (Kiro Crew Issue Radar)