Support for initialized atomics and __c11_atomic_signal_fence - #2006
Draft
brk wants to merge 2 commits into
Draft
Conversation
Contributor
|
I think this is already covered by #2001. |
ahomescu
reviewed
Sep 10, 2026
| } else if let &CTypeKind::IncompleteArray(_) = resolved_ty { | ||
| // Incomplete arrays are translated to zero length arrays | ||
| Ok(WithStmts::new_val(mk().array_expr(vec![]))) | ||
| } else if let &CTypeKind::Atomic(ty) = resolved_ty { |
ahomescu
reviewed
Sep 10, 2026
| // compile time, so we only support a constant one. A relaxed fence | ||
| // is a no-op (and Rust has no relaxed fence intrinsic), so we drop it. | ||
| "__atomic_thread_fence" | "__atomic_signal_fence" => { | ||
| "__atomic_thread_fence" | "__atomic_signal_fence" | "__c11_atomic_signal_fence" => { |
Contributor
There was a problem hiding this comment.
I don't see this in the other PR, I think we keep it.
Contributor
brk
marked this pull request as draft
September 10, 2026 12:06
Contributor
Author
|
web merge on github looks like it will duplicate the Atomic initializer clause, will fix by hand in a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1667.
AI disclosure: this code was written by Codex.