Repository navigation
build: lint on the tsrs Vite+ 1.7 bundles and drop the tsrs-lint shim - #756
Merged
Merged
Conversation
Vite+ 1.7.0 runs oxlint's type-aware lint and type-check on its bundled tsrs, so the oxlint-tsgolint override, tools/tsrs-lint-shim, the root tsrs and the OXLINT_TSGOLINT_PATH assignment in vite.config.ts go. Vitest stays at 5.0.5, with @vitest/browser-preview overridden too so vite-plus/test resolves a single Vitest. oxfmt 0.79 reformats four files.
Owner
Author
Review report — head 52c572aTwo-axis review (Standards, Spec) of Fixed: ADR-0055 still described the shim, Dismissed / advisory:
No blockers remain. |
Preview deployedURL: https://cloudpid-server-pr-756.ian-g-pascoe.workers.dev Built from f44c5e3 (stage This comment updates on each push. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vite+ 1.7.0 bundles tsrs and runs oxlint's type-aware lint and type-check on it (oxc blog, 2026-11-17), so the shim that swapped tsrs in for tsgolint goes.
@vitest/browser-preview@5.1.0; that second copy gavevite-plus/testa second Vitest, so the workerd tests'ProvidedContextaugmentation missed it (inject(...)→never) and the server's typecheck failed. Overriding it to 5.0.5 fixes that.OXLINT_TSGOLINT_PATHis no longer touched invite.config.ts. Vite+ sets it in its own process before loading the config, so deleting it there made oxlint fall back to atsgolintonPATH(a globaloxlint-tsgolint).vite-plusandtsrsrows), ADR-0055 (Versions, Consequences), ADR-0028 status.Evidence
vp lintover the repo, 8-core Apple Silicon:After (Vite+ 1.7's tsrs
7.1.0-beta.tsrs2): 4.5 s wall, 16 s CPU, 1.47 GB peak; backend process@tsrs/darwin-arm64@7.1.0-beta.tsrs2 … tsrs --lint headlessconst n: number = "x"and an unawaited async call still reportstypescript(TS2322)andtypescript(no-floating-promises).vp checkpasses;pnpm run typecheck16/16;apps/webbuild passes;pnpm test4832 passed, 2 failed inbash.workerd.test.ts(plus afiles.workerd.test.tsload failure) under heavy machine load, all passing when rerun alone.Merge Danger
Door: two-way
Revert restores the shim and Vite+ 1.4.0.
Blast Radius: tooling
Lint, format and the Vite core of every package's tests and the web build move to Vite+ 1.7 / Vite 8.3.8; CI runs the full suite.
Plan
Remove the hack used to run oxlint's type-aware lint on tsrs (the
tools/tsrs-lint-shim, itsoxlint-tsgolintoverride, the roottsrsand theOXLINT_TSGOLINT_PATHassignment) now that Vite+ 1.7.0 ships tsrs as its backend; upgrade Vite+ to 1.7.0, keep Vitest at 5.0.5, and update the docs that describe the setup.