ADP-1490: add new Prometheus client for Flink scrape compatibility and wire the existing collector to that - #149
Merged
Merged
Conversation
avinashkolluru
previously approved these changes
Aug 2, 2026
anujgoyal1
previously approved these changes
Aug 3, 2026
varkey98
dismissed stale reviews from anujgoyal1 and avinashkolluru
via
August 3, 2026 12:25
66589cc
varkey98
requested review from
anujgoyal1,
avinashkolluru,
ravisingal and
tim-mwangi
August 3, 2026 12:26
avinashkolluru
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharedMeterRegistry.getOrCreatePrometheusRegistry(serviceName, port)for Flink TaskManagers: one-time process init via a new config-freePlatformMetricsRegistry.initMetricsRegistryForFlink(String)(pins theprometheusreporter and falls back to defaults for everything else), binds a standalone Prometheus scrape endpoint usingHTTPServer(prometheus-metrics-exporter-httpserver), and returns the sharedPrometheusRegistryso a Flink reporter can bridge Flink-native metrics onto the same endpoint. Application meters still go throughPlatformMetricsRegistry.getMeterRegistry(). ExistinginitMetricsRegistry(String, Config)callers keep API parity.PlatformMetricsRegistry.getPrometheusRegistry().Test plan
:platform-metrics:testand:platform-service-framework:testpass/metricsscrapes Micrometer + Dropwizard metrics after service startupCollectorRegistrymetrics are bridged onto the sharedPrometheusRegistrySharedMeterRegistry.getOrCreatePrometheusRegistry(serviceName, port)without loading typesafe-config as parent-firstinitMetricsRegistry(serviceName, config)callers still behave as before