Skip to content

ADP-1490: add new Prometheus client for Flink scrape compatibility and wire the existing collector to that - #149

Merged
varkey98 merged 14 commits into
mainfrom
flink-metrics
Aug 3, 2026
Merged

ADP-1490: add new Prometheus client for Flink scrape compatibility and wire the existing collector to that#149
varkey98 merged 14 commits into
mainfrom
flink-metrics

Conversation

@varkey98

@varkey98 varkey98 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adding a new prometheus registry for serving both flink related metrics and the metrics which get initiated via PlatformMetricsRegistry.
  • Add SharedMeterRegistry.getOrCreatePrometheusRegistry(serviceName, port) for Flink TaskManagers: one-time process init via a new config-free PlatformMetricsRegistry.initMetricsRegistryForFlink(String) (pins the prometheus reporter and falls back to defaults for everything else), binds a standalone Prometheus scrape endpoint using HTTPServer (prometheus-metrics-exporter-httpserver), and returns the shared PrometheusRegistry so a Flink reporter can bridge Flink-native metrics onto the same endpoint. Application meters still go through PlatformMetricsRegistry.getMeterRegistry(). Existing initMetricsRegistry(String, Config) callers keep API parity.
  • Expose the shared registry via PlatformMetricsRegistry.getPrometheusRegistry().

Test plan

  • :platform-metrics:test and :platform-service-framework:test pass
  • Confirm /metrics scrapes Micrometer + Dropwizard metrics after service startup
  • Confirm the deprecated simpleclient CollectorRegistry metrics are bridged onto the shared PrometheusRegistry
  • Confirm Flink path can initialize via SharedMeterRegistry.getOrCreatePrometheusRegistry(serviceName, port) without loading typesafe-config as parent-first
  • Confirm existing initMetricsRegistry(serviceName, config) callers still behave as before

@varkey98
varkey98 requested a review from a team as a code owner July 30, 2026 08:27
@varkey98 varkey98 changed the title ADP-1490: update to use new prometheus client for flink compatibility ADP-1490: update to use new prometheus client for flink compatibility and adding a v2 metrics api Jul 30, 2026
@varkey98 varkey98 changed the title ADP-1490: update to use new prometheus client for flink compatibility and adding a v2 metrics api ADP-1490: migrate to new Prometheus client for Flink scrape compatibility Jul 31, 2026
@varkey98 varkey98 changed the title ADP-1490: migrate to new Prometheus client for Flink scrape compatibility ADP-1490: add new Prometheus client for Flink scrape compatibility and wire the existing collector to that Aug 2, 2026
avinashkolluru
avinashkolluru previously approved these changes Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

Test Results

32 tests  ±0   32 ✅ ±0   18s ⏱️ -1s
 9 suites ±0    0 💤 ±0 
 9 files   ±0    0 ❌ ±0 

Results for commit 66589cc. ± Comparison against base commit 4db4b1d.

♻️ This comment has been updated with latest results.

anujgoyal1
anujgoyal1 previously approved these changes Aug 3, 2026
@varkey98
varkey98 merged commit b879491 into main Aug 3, 2026
4 checks passed
@varkey98
varkey98 deleted the flink-metrics branch August 3, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants