Skip to content

docs: add Signed commits section to CONTRIBUTING - #62

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218
Oct 1, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

This repo's default branch is covered by the zero-bypass Require-Signed-Commits ruleset, and rebase-merge is off. The section tells contributors what that requires:

  • People and interactive agents sign with an SSH signing key.
  • Apps, bots and workflows write through the API, so GitHub signs their commits.
  • PRs are merged with squash.

If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).

This is a docs-only change. The commit was created through createCommitOnBranch, so GitHub signs it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f

Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 14aa5956-4245-4efb-8965-20776ee8f1eb

📥 Commits

Reviewing files that changed from the base of the PR and between 0a00bcf and 8d08035.

📒 Files selected for processing (1)
  • CONTRIBUTING.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (17)
  • GitHub Check: scan / rust-secrets
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Security policy checks
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: scan / gitleaks
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: trufflehog
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: Analyze (actions)
  • GitHub Check: semgrep-cloud-platform/scan

📝 Summary

Summary by CodeRabbit

  • Documentation
    • Added contribution guidance requiring signed commits on the default branch, with specific signing requirements for people, agents, apps, bots and workflows.
    • Clarified that contributors must squash-merge; unsigned commits block merging, and rebase-merging is unavailable.

Walkthrough

CONTRIBUTING.adoc now sets signed-commit requirements for changes reaching the default branch. It describes signing methods for people, interactive agents, apps, bots, and workflows, and states the rules for unsigned PR branches and squash merging.

Changes

Signed commit policy

Layer / File(s) Summary
Contributor signing and merge requirements
CONTRIBUTING.adoc
Adds SSH signing and verified-email requirements for people and interactive agents. Apps, bots, and workflows must use the API or the estate signed-push action. The guidance states that unsigned PR branches block merging and that contributors must squash-merge.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: metadatastician

Merge Risk: ⚪ Minimal · up to 8d080

The signing guidance introduces no demonstrated merge-blocking issue. The documentation change is mergeable subject to normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 8d080

Only contribution guidance changes, with no implementation or permission changes. The signing requirements clarify contributor responsibilities, but the repository settings and referenced automation were not verified, so their documented guarantees remain unconfirmed.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • observed — The policy addresses commits reaching this repository's default branch. The PR contains no changes to credentials, IAM permissions, application authorization, deployment configuration, or data access.

Trust Boundaries and Controls

  • observed — People and interactive agents are instructed to use a GitHub-registered SSH signing key and verified committer email. Apps, bots, and workflows are instructed to use API-mediated commits for GitHub signing. These are documented procedures, not newly implemented controls or evidence of additional authority.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change and names the Signed commits section added to CONTRIBUTING.
Description check ✅ Passed The description directly explains the docs-only change, its signing policy context, and the contributor guidance added to CONTRIBUTING.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each signed commit,
Then hops along the squash-merge trail.
The branch is ready, signatures set,
No unsigned push can cross the gate.
A quiet carrot crowns the change.

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

@hyperpolymath
hyperpolymath merged commit a8b4be7 into main Oct 1, 2026
19 of 24 checks passed
@hyperpolymath
hyperpolymath deleted the docs/signing-policy-d218 branch October 1, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant