Skip to content

Arena/01a10a3c standards - #1196

Closed
hyperpolymath wants to merge 8 commits into
mainfrom
arena/01a10a3c-standards
Closed

hyperpolymath wants to merge 8 commits into
mainfrom
arena/01a10a3c-standards

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Closes #

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (would change existing behaviour)
  • 🕳️ Soundness fix (fixes a checker/proof false-negative)
  • 📖 Documentation
  • 🧹 Refactor / tech debt (behaviour-preserving)
  • ⚡ Performance
  • 🔧 Build / CI / tooling

How has this been verified?

Checklist

  • My commits are signed (git commit -S).
  • I ran the project's own checks/tests locally and they pass.
  • New files carry the correct SPDX-License-Identifier (code/config MPL-2.0,
    prose CC-BY-SA-4.0); I did not relicense existing files.
  • Docs are updated, and no public claim now overstates what the code does.
  • I have not introduced a soundness hole (or I have flagged where I might have).

Notes for reviewers

hyperpolymath and others added 8 commits October 5, 2026 04:10
MIGRATION-1058 M3 (standards#1058, issue #C). A template is never loaded, so
it must not claim the reserved `.k9.ncl` component suffix. The three trust-tier
templates keep their TODO placeholders — that is the point of a template — and
become `template-*.k9.ncl.in`, outside every scope that reads `*.k9`/`*.k9.ncl`
as a loadable component (the pre-commit hook, the corpus walk, CI's Nickel
pathspec).

`setup-repo.k9.ncl` keeps the suffix because it IS a component, and is fixed
as one: its grant pays for all three security flags (`net.fetch`, `fs.write`,
`process.spawn` — K9-S007/§8.4), `side_effects` names what the recipes
actually do (K9-S010/§6.5), and a `signature` block is present
(K9-S009/§10.1) whose header says, per §10.2, that presence is not
verification.

- ledger: 17 → 13 — the four M3 entries removed, shrink-only ratchet intact
- docs repointed: svc/k9 README, contractiles README + INDEX.a2ml, canonical
  templates, CONTRACTILE-SPEC, K9-CONTRACT-SPEC, ADR-001 amendment note
- REGISTRY.a2ml regenerated with `just registry` (also refreshes three hashes
  already stale on main: 1-formats/k9, 2-protocols/axel, form-fill-provenance)

Verified: --self-test passes; --fixtures 5 positive / 21 negative / 0
failures; L1 clean on the four svc/k9 components; the hook is green for this
change set (1 conforming, 0 grandfathered). The corpus hook still exits 1 on
the pre-existing contractile (#A) and axel (#D) failures, untouched here.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Resolve conflict in k9-contract-debt.txt by accepting PR version
(removes 4 template entries, count 13).

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Remove k9 from INDEX.a2ml verb registry (now only 6 verbs, no exceptions).
Update README.adoc and CONTRACTILE-SPEC.adoc to reflect k9 relocation to
.machine_readable/svc/k9/ estate-wide. Rename [[k9-exception]] anchor to
[[k9-relocation]] for clarity.

Addresses CodeRabbit review comment on PR #1148 lines +176-+181.

Signed-off-by: Mistral Vibe <vibe@mistral.ai>
Resolve merge conflicts by accepting main branch changes:
- Remove k9 exception from contractile registry (INDEX.a2ml)
- Update README.adoc to reflect k9 relocation
- Update CONTRACTILE-SPEC.adoc tree diagram and registry description
- Fix subpath pin in codeql-reusable.yml (init@ → @)

These changes align with ADR-001 which relocated k9 to .machine_readable/svc/k9/
and removes it from the contractile verb registry.
This fixes the merge conflict by accepting the main branch's removal of k9
exception from the contractile registry, per ADR-001.

- INDEX.a2ml: k9 removed from [[verbs]] section
- README.adoc: Updated to reflect k9 relocation to .machine_readable/svc/k9/
- CONTRACTILE-SPEC.adoc: Updated tree diagram and registry description
- codeql-reusable.yml: Fixed subpath pin (init@ → @)
Resolve conflicts by accepting main branch changes for:
- REGISTRY.a2ml (hash updates from #1151, #1149)
- k9-contract-debt.txt (ledger updates)
- k9_contract.ncl (template file references)

This incorporates all changes from main into the PR branch.
Amendment 2026-10-05 (standards#1058, MIGRATION-1058 M3) added note that
templates now carry the .in suffix, but tree diagram was not updated.
This commit updates the tree to match the amendment.

Fixes CodeRabbit review comment on PR #1148.

SPDX-License-Identifier: CC-BY-SA-4.0
Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: bc61ba98-7019-4da6-bf04-586f3d15e2a2
📥 Commits

Reviewing files that changed from the base of the PR and between 8453510 and e2df049.

📒 Files selected for processing (18)
  • .machine_readable/REGISTRY.a2ml
  • .machine_readable/contractiles/INDEX.a2ml
  • .machine_readable/contractiles/README.adoc
  • .machine_readable/k9-contract-debt.txt
  • .machine_readable/svc/k9/README.adoc
  • .machine_readable/svc/k9/examples/setup-repo.k9.ncl
  • .machine_readable/svc/k9/template-hunt.k9.ncl.in
  • .machine_readable/svc/k9/template-kennel.k9.ncl.in
  • .machine_readable/svc/k9/template-yard.k9.ncl.in
  • 1-formats/contractiles/CANONICAL-TEMPLATES.adoc
  • 1-formats/k9/spec/K9-CONTRACT-SPEC.adoc
  • 1-formats/k9/spec/MIGRATION-1058.adoc
  • 1-formats/k9/spec/contract/k9_contract.ncl
  • 1-formats/k9/tools/fixtures/invalid/L1-K9-S003-todo-component-type.k9.ncl
  • docs/ADR-001-k9-relocation-to-svc.adoc
  • docs/CONTRACTILE-SPEC.adoc
  • scripts/check-lock-sync.sh
  • scripts/tests/check-lock-sync-test.sh
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath enabled auto-merge (squash) October 7, 2026 10:02
@hyperpolymath
hyperpolymath disabled auto-merge October 7, 2026 10:53
@hyperpolymath

Copy link
Copy Markdown
Owner Author

Closing as superseded by #1154 ("Pr 1148 fixed", 44ca61e2). This branch replays the same pr-1148 work. Automerge disarmed first.

Blob comparison of this head against main (85aa1934): 15 of the 18 files are byte-identical to main. The 3 that differ would regress main:

File Effect of merging
1-formats/k9/spec/contract/k9_contract.ncl Reverts #1175 (D310): removes the .. open-record tails and their §5.5 rationale
.machine_readable/REGISTRY.a2ml Reverts five source_hash values refreshed by #1187
docs/ADR-001-k9-relocation-to-svc.adoc A genuine fix: the tree lists templates as *.k9.ncl.in

The ADR-001 tree fix is cherry-picked on its own into a separate PR, which will be linked below.

🤖 Generated with Claude Code

@hyperpolymath

Copy link
Copy Markdown
Owner Author

Correction to my comment above: no salvage PR will be opened. On main, docs/ADR-001-k9-relocation-to-svc.adoc already records the .in rename as a dated [NOTE] amendment (2026-10-05, MIGRATION-1058 M3) and deliberately keeps the decision-time tree. This branch's edit rewrites that historical tree, which makes the amendment redundant. It is not an improvement, so nothing from #1196 remains to land.

🤖 Generated with Claude Code

@hyperpolymath
hyperpolymath deleted the arena/01a10a3c-standards branch October 8, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant