Repository navigation
fix(governance): R5 scan no longer exits silently under bash -e - #1163
Merged
Merged
Conversation
The #1160 relock regenerated actions.lock from .github/workflows/ only and dropped the dependency used by the composite action .github/actions/signed-push/action.yml:42. `uses ⊆ actions.lock` has been red on main since ce92a8c ("not in actions.lock: Asana/push-signed-commits@d615ca88"). This restores the entry byte for byte as it stood on 5751b97 (ref v1.3, same commit and ids, same transitive uses). Verified: .githooks/validate-actions-lock.sh rc=1 before (1 ref missing), rc=0 after (26/26); scripts/check-lock-sync.sh rc=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P48P9ErT8UFFeDUfEQiYV7
The R5 step runs under `bash -e`. A bare `out=$(grep ...)` that matched nothing returned 1 and killed the step before `rc` was read, so a clean file aborted the scan with no message. Capture the status with `|| rc=$?` instead. tests/test_governance_r5_bash_e.sh drives the extracted loop: RED 3/4 before the fix (no-match case exited early), GREEN 4/4 after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P48P9ErT8UFFeDUfEQiYV7
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
K9 contract conformancerun https://github.com/hyperpolymath/standards/actions/runs/37473506373 K9 normative contract typecheckK9 contract self-testK9 conformance fixtures |
|
5 of 13 tasks
Contributor
|
Add Carrot credits or activate Agent usage billing to use Autopilot |
Contributor
|
❌ Failed to create Coding Agent finishing-touch task. Please try again. |
4 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The R5 (route-to-canonical) step in
.github/workflows/governance-reusable.ymlruns underbash -e.out=$(grep -nE …)returns 1 when a pattern does not match, and that killed the step beforercwas read. So the first clean file ended the scan with no output, and every later file went unscanned. This PR keeps the status with|| rc=$?.Stacked on #1162 (the asana lock restore). Without #1162, the pre-commit
uses ⊆ actions.lockhook refuses any commit on main. Once #1162 merges, this branch will be updated, and the diff will be the R5 commit only.Type of change
📌 New pins
uses:or lock entry is changed by the R5 commit. The base commit e4641ca (fix(lock): restore Asana/push-signed-commits entry dropped by #1160 #1162) restores the existing Asana/push-signed-commits@d615ca8 entry.How has this been verified?
bash tests/test_governance_r5_bash_e.sh: RED 3/4 before the fix, because the no-match case exited early. GREEN 4/4 after it..githooks/docstring-scan.sh --staged: 3/3 functions documented, coverage 100%.Checklist
tests/test_governance_r5_bash_e.shcarriesSPDX-License-Identifier: MPL-2.0.Notes for reviewers
Every caller pinned to a governance-reusable SHA before this fix keeps the silent-exit behaviour until it repins. echidna's six standards callers will be repinned in a follow-up PR once this lands.
🤖 Generated with Claude Code
https://claude.ai/code/session_01P48P9ErT8UFFeDUfEQiYV7