chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest - #95
chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest#95hyperpolymath wants to merge 3 commits into
Conversation
…the rest
Estate top-up pass. Three separate things, none of which invents a value.
FILLED — every token with a single mechanical answer: OWNER, REPO, FORGE,
PROJECT, PACKAGE_NAME, PROJECT_NAME, AUTHOR, AUTHOR_EMAIL, CONDUCT_EMAIL,
AUTHOR_FIRST/LAST/INITIALS, CURRENT_YEAR, CURRENT_DATE, DATE, MAIN_BRANCH.
Identity comes from the git remote, dates from the clock, project name from the
README H1 where there is one.
Deliberately NOT filled, because more than one defensible answer exists and a
confident wrong value is worse than a visible gap: SECURITY_EMAIL (two competing
addresses are in use across the estate), RESPONSE_TIME, CONDUCT_TEAM (which
substitutes into "a {{CONDUCT_TEAM}} member", not English), WEBSITE,
PROJECT_DESCRIPTION, LANG_STACK.
DELETED — ARCHITECTURE.md, where it is byte-identical to the 346-copy estate
boilerplate (blob 607e3d8). Those 33 lines describe a src/ tests/ docs/
scripts/ config/ tree that this repo does not have, so the file is not merely
uninformative, it is wrong. Genuinely written ARCHITECTURE files are matched by
hash and left alone. No file beats a confidently false one.
CODEOWNERS — rewritten to the solo form mandated by
hyperpolymath/standards CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all
line where the only owner is the sole maintainer. The estate's own
templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and
resolves standards#55, so it wins. Files naming a genuine co-owner are Rule 2
and are untouched. Note @hyperpolymath and @metadatastician are the same person,
so a file naming the other account is a copy artifact that silently routed
review requests to the wrong account.
SURFACED — REQUIRES_INITIALISATION.md, and a priority action in
0-AI-MANIFEST.a2ml. Tokens that need a decision no script can make are left
visibly unfilled rather than faked or quietly deleted. The marker says what each
one is, which files it belongs in, why it was not done already, and that it must
be deleted only once the work is genuinely finished.
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
| # --------------------------------------------------------------- | ||
| devShells.default = pkgs.mkShell { | ||
| name = "{{PROJECT_NAME}}-dev"; | ||
| name = "PanLL eNSAID-dev"; |
There was a problem hiding this comment.
🚨 Bug: Project name with space produces invalid Nix/Guix identifiers
PROJECT_NAME was filled with the display string "PanLL eNSAID" (contains a space) and substituted into contexts that require valid identifiers, breaking the builds. In panel-clades/flake.nix, pname = "PanLL eNSAID", name = "PanLL eNSAID-dev" and the derivation name are illegal — Nix rejects spaces in derivation names, so nix build/nix develop will fail. In panel-clades/.guix-channel, (name 'PanLL eNSAID) is an invalid Scheme symbol and will break guix pull. In panel-clades/.devcontainer/Containerfile, WORKDIR /workspaces/PanLL eNSAID and podman build -t PanLL eNSAID-dev split on the space. Use a slug (e.g. panll / panel-clades) for identifier/path/tag contexts and keep the human-readable name only for description fields.
Was this helpful? React with 👍 / 👎
| meta = with pkgs.lib; { | ||
| description = "{{PROJECT_DESCRIPTION}}"; | ||
| homepage = "https://github.com/{{OWNER}}/{{PROJECT_NAME}}"; | ||
| homepage = "https://github.com/hyperpolymath/PanLL eNSAID"; |
There was a problem hiding this comment.
⚠️ Bug: Homepage/URL uses PROJECT_NAME instead of REPO, yielding bad URL
panel-clades/flake.nix line 162 now reads homepage = "https://github.com/hyperpolymath/PanLL eNSAID" and panel-clades/.guix-channel uses https://github.com/hyperpolymath/PanLL eNSAID. These substitute the project display name into the repo-slug position of a GitHub URL, producing a URL that both contains a space and points at a non-existent path (the repo is panll). Use the {{REPO}} value (panll) here, not {{PROJECT_NAME}}.
Was this helpful? React with 👍 / 👎
|
|
||
| [methodology.state-validation] | ||
| reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"] | ||
| reject-if-contains = ["{{PLACEHOLDER}}", "PANLL", "rsr-template-repo"] |
There was a problem hiding this comment.
⚠️ Bug: State-validation reject list now contains the real project name
.machine_readable/agent_instructions/methodology.a2ml changed reject-if-contains from {{PROJECT}} to the literal "PANLL". This list is meant to detect unfilled template/corrupt state files, but PANLL is the actual project name, so any legitimate STATE.a2ml that mentions the project will now be flagged as corrupt/template and rejected. Drop this entry (or restore a template-only marker); the real project name must not be a rejection trigger.
Was this helpful? React with 👍 / 👎
| | `Jonathan D.A. Jewell`=Jonathan D.A. Jewell, `j.d.a.jewell@open.ac.uk`=j.d.a.jewell@open.ac.uk, | ||
| `hyperpolymath`=hyperpolymath, `github.com`=github.com, `panll`=panll, | ||
| `2026`=2026, `2026-08-05`/`{{GENERATED_AT}}`=instantiation date, | ||
| `{{VERSION}}`=0.1.0, `{{PASCAL_NAME}}`=PanelClades, `PANLL`=PANEL_CLADES, |
There was a problem hiding this comment.
💡 Quality: Placeholder-doc table corrupted by blanket substitution
docs/architecture/P2-COPROCESSOR-CLADE-DESIGN.adoc documents the token vocabulary, so substituting into it produces nonsense rows like Jonathan D.A. Jewell`=Jonathan D.A. Jewell and replaces the {{CONDUCT_EMAIL}} example token with an actual email inside a {{SECURITY_EMAIL}}/.../{{CONDUCT_TEAM}} list. This defeats the file's purpose of listing tokens. Exclude doc/spec files that intentionally contain token literals from the top-up pass and revert these lines.
Was this helpful? React with 👍 / 👎
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review 🚫 Blocked 0 resolved / 4 findingsAutomated estate top-up that populates derivable placeholders and removes boilerplate architecture documentation. Blocked by critical identifier failures from spaces in PROJECT_NAME, broken URL formatting, state validation rejection issues, and placeholder-doc table corruption. 🚨 Bug: Project name with space produces invalid Nix/Guix identifiers📄 panel-clades/flake.nix:95 📄 panel-clades/flake.nix:101 📄 panel-clades/flake.nix:134 📄 panel-clades/flake.nix:162 📄 panel-clades/.guix-channel:9-10 📄 panel-clades/.guix-channel:17 📄 panel-clades/.devcontainer/Containerfile:6 📄 panel-clades/.devcontainer/Containerfile:27 PROJECT_NAME was filled with the display string "PanLL eNSAID" (contains a space) and substituted into contexts that require valid identifiers, breaking the builds. In panel-clades/flake.nix,
|
| Compact |
|
Important
Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.
Was this helpful? React with 👍 / 👎 | Gitar
There was a problem hiding this comment.
Configure merge blocking · Maintainers can dismiss this review.
…t a value
The estate top-up sweep substituted {{PROJECT}} here along with every other
token. This line is a DETECTOR list: the comment above it says these rules
detect corrupt/template/stale state files, so the tokens named in it are the
ones whose PRESENCE means a state file is broken.
Substituting it did two things. It blinded the {{PROJECT}} leak detector, and it
made the detector reject any state file containing this repo's own uppercased
name — the opposite of what the rule is for.
Same failure class as a template recipe rewriting the incident record that
documents its own bug: substituting tokens inside a thing that is ABOUT tokens.
Nothing else in this PR changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The previous commit on this branch was written by a script that read the file through a shell command substitution. $(...) strips trailing newlines and printf '%s' does not put one back, so the file lost its final newline and the diff showed "\ No newline at end of file". Content is otherwise byte-identical to that commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
1 participant
Automated estate top-up. Nothing here invents a value.
Filled — every token with one mechanical answer (owner, repo, forge, author, dates, project name, main branch). Identity from the git remote, dates from the clock, name from the README H1.
Not filled, on purpose —
SECURITY_EMAIL(two competing addresses exist in the estate),RESPONSE_TIME,CONDUCT_TEAM(substitutes into "a {{CONDUCT_TEAM}} member", which is not English),WEBSITE,PROJECT_DESCRIPTION,LANG_STACK. More than one defensible answer exists, and a confident wrong value is worse than a visible gap.Deleted —
ARCHITECTURE.mdwhere it is byte-identical to the 346-copy estate boilerplate (blob607e3d8c). Those 33 lines describe asrc/ tests/ docs/ scripts/ config/tree this repo does not have. Matched by hash, so a genuinely written ARCHITECTURE can never be caught by it.CODEOWNERS — the solo form from
standards/CODEOWNERS-POLICY.adocRule 1, which forbids a catch-all where the only owner is the sole maintainer.templates/CODEOWNERScontradicts that policy; the policy is versioned, dated and resolvesstandards#55, so it wins. Genuine co-owners (Rule 2) are untouched.Surfaced —
REQUIRES_INITIALISATION.mdplus a priority action in0-AI-MANIFEST.a2ml, listing every remaining token, what it means, which files it belongs in, why it was not done already, and that it is to be deleted only when the work is genuinely complete.Built from a fresh clone of
origin/main, never a local checkout — several of those are dirty and hold unpushed commits.🤖 Generated with Claude Code