Repository navigation
chore(toolchain): pin the patched Lean v4.34.1 - #39
Conversation
CodeRabbit review on #36 (Major, security): v4.34.1 is the patched release of the 4.34 line. Checked against leanprover/lean4 itself: v4.34.0..v4.34.1 adds three runtime reference-count fixes (leanprover/lean4#15241, #15288, #15307), a BitVec backport and release preparation. marches checks only its own proofs, so the practical risk was low; the patch keeps the soundness floor on the patched build. lean-toolchain, README's two version mentions, and a STATE entry. Gates (v4.34.1): lake build -> Build completed successfully (15 jobs); grep -rnw sorry empty; #eval orbit unchanged. Rung: 3 (housekeeping; rung stays OPEN) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTeVWDEJgdYKsUNr4uhnXX
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Generated by Claude Code |
Follow-up to the CodeRabbit review on #36 (thread on
lean-toolchain, flagged Major / security): pin v4.34.1, the patched release of the 4.34 line.Verified against the primary source, not the bot's summary
git log v4.34.0..v4.34.1in leanprover/lean4 shows:sharecommon_quick_fnleanprover/lean4#15307: panic instead of wrapping counts insharecommon_quick_fnBitVec.ofNatClampbackportchore: prepare release(5045d00, 2026-09-24)marches checks only its own proofs, not untrusted input, so the practical risk was low. Still, this is a same-line patch bump, it costs nothing, and it keeps the estate's 4.34 soundness floor on the patched build.
Change
lean-toolchain:v4.34.0→v4.34.1README.adoc: the two version mentionsSTATE.adoc: a dated entry. The v4.34.0 results are now marked historical.No source change.
Gates (v4.34.1)
Note on the stack
#38 (rung-3 docs) is independent of this PR. Both add a
STATE.adocentry at the top, so whichever merges second will need a trivial merge, which I'll handle.CI here shows the same two pre-existing reds as
main(CIstartup_failurefromactions.lockdrift, andestate-auditfrom the cicd-suite pipefail bug). Both are diagnosed in #37.🤖 Generated with Claude Code
https://claude.ai/code/session_01VTeVWDEJgdYKsUNr4uhnXX
Generated by Claude Code