Repository navigation
fix(ci): relock actions.lock for Dependabot-bumped refs; codeql to v4.38.2 symbolic (#914, #901) - #915
Merged
Conversation
….38.2 symbolic Regenerated with hyperpolymath/standards scripts/update-actions-lock.sh (standards 900c42c7, gh-actions-lock v0.1.6), not edited by hand: - taiki-e/install-action v2.87.22 -> v2.87.24 (commit e407f7ba), in build-gossamer-gui, ci, security-policy and tests; - hyperpolymath/smtp-notify-action v0.3.0 -> v0.5.0 (commit c1c9fa07), in push-email-notify; - github/codeql-action: the tool rewrote the bare 2892aa5e refs in codeql.yml and security-policy.yml to the symbolic v4.38.2 and locked v4.38.2 -> 2892aa5e. Same commit. Drops the false "# v4.38.0" label. Closes #914 Closes #901 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015bTuGfwCcvjrmNFejydTML
6 tasks done
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This relocks
.github/workflows/actions.lockfor the refs Dependabot bumped without regenerating the lock. That desync is the consistent explanation for the four workflows that die at startup onmain:CI,Tests (E2E / Integration / Stress / Bench),SecurityandBuild Gossamer GUI. While they do, hypatia CI runs no Elixir test suite at all. This PR also fixes thecodeql.ymlstartup death (#901).The lock was regenerated with the estate tool,
hyperpolymath/standardsscripts/update-actions-lock.sh(standardsorigin/main@900c42c7,gh-actions-lockv0.1.6), not edited by hand. The same procedure fixed gitbot-fleet in hyperpolymath/gitbot-fleet#605.taiki-e/install-actionv2.87.22→v2.87.24, inbuild-gossamer-gui.yml,ci.yml,security-policy.ymlandtests.yml.hyperpolymath/smtp-notify-actionv0.3.0→v0.5.0, inpush-email-notify.yml.github/codeql-action: the tool rewrote the bare-SHA refs@2892aa5e…(5 lines acrosscodeql.ymlandsecurity-policy.yml) to the symbolic@v4.38.2and lockedv4.38.2→2892aa5e…. This is the same commit, so the code that runs does not change. It is the fix pattern codeql.yml uses a bare commit the lock does not vouch for, and mislabels it as v4.38.0 #901 prescribes ("symbolic; the lock carries the SHA"), and it drops the false# v4.38.0label on that commit.Closes #914
Closes #901
Type of change
mainthat kills 5 workflows at startup and turns 2 governance checks red.actions.lockregeneration, plus the tool's codeql ref rewrite.📌 New pins
ddc77bc2fa8ab0241a8367ab2f53344eb9316071actions.lock:taiki-e/install-action@v2.87.24→ commite407f7bafb71fd004bc5c2da3032e5470cbb6ef0. It replaces@v2.87.22(83ac0ad6…).actions.lock:hyperpolymath/smtp-notify-action@v0.5.0→ commitc1c9fa07992a02c1fd3d67a0dc1b08cccb852aef. It replaces@v0.3.0(22e7bdb3…).actions.lock: newgithub/codeql-action@v4.38.2→ commit2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2, now listed undercodeql.ymlandsecurity-policy.yml.uses::github/codeql-action/{init,analyze,upload-sarif}@2892aa5e…→@v4.38.2, on 5 lines. Same commit.git ls-remoteagainst the peeled commit (refs/tags/<t>^{}), not the annotated tag object.uses:line, lockfile record or container digest changes.How has this been verified?
All commands were run in the PR worktree at the head above, unless stated otherwise.
update-actions-lock.sh, update mode: exit 0. It reports "Pinned 3 actions across 6 workflows", and its built-inverify_lock_coveragepass also succeeded.gh actions-lock --no-fix: exit 0.gh actions-lock --no-fixon agit archive origin/mainexport exits 1. It prints 4 ×Ref changed taiki-e/install-action@v2.87.24, 4 ×Unused lockfile entry …@v2.87.22,Ref changed hyperpolymath/smtp-notify-action@v0.5.0andUnused lockfile entry …@v0.3.0, which are exactly actions.lock desync (taiki-e v2.87.24, smtp-notify v0.5.0) turns lockfile-verify and Hypatia Baseline red on main #914's findings. So the pass above is not vacuous.git ls-remotefor each tag:taiki-e/install-actionv2.87.24^{}=e407f7ba…,github/codeql-actionv4.38.2^{}=2892aa5e…,hyperpolymath/smtp-notify-actionv0.5.0^{}=c1c9fa07…. All three match the lock.actionlinton the two rewritten workflows: 25 findings, all[shellcheck]info-level, identical to the same files onorigin/main(compared with line numbers stripped). None are introduced.git log -1 --show-signaturereports a good ED25519 signature, asrequired_signaturesneeds.ddc77bc2:governance / Validate Hypatia Baselinepasses. So the relock alone cleared the 5unpinned_actionfindings, with no inline SHA pins and no re-ACK.CI Status,Rust Tests,Cargo test,Integration Tests,E2E — Elixir Scanner Pipeline,stress-test,CodeQLandCodeQL Analysis (actions).Build Gossamer GUIhas apaths:filter this PR doesn't match, so it was run withworkflow_dispatchon this branch. Run 37833436482 succeeded, 3/3 jobs. Its last three runs elsewhere, includingmain, were allstartup_failure.governance / Actions lockfile verifypasses.abi-codegen-drift,zig build test (FFI + wire contract),Escript packaging soundnessandscan / gitleaks.Red checks, deferred
security-policy.ymlnow runs for the first time since the desync, and three of its jobs fail. None of them is caused by this PR, and none is required. Root causes and acceptance criteria are in #916:Rust Dependency Audit: deferred to security-policy.yml: 3 pre-existing failures surfaced once the workflow starts (deferred from #915) #916. Two real advisories inCargo.lock, RUSTSEC-2026-0204 (crossbeam-epoch) and RUSTSEC-2026-0258 (h2).Rust License & Ban Check: deferred to security-policy.yml: 3 pre-existing failures surfaced once the workflow starts (deferred from #915) #916. The workflow generates adeny.tomlthat current cargo-deny cannot parse (unmaintained = "warn").Security Status: deferred to security-policy.yml: 3 pre-existing failures surfaced once the workflow starts (deferred from #915) #916. The orphan-job self-check reads the workflow file without a checkout step and crashes with exit 2.Checklist
SPDX-License-Identifier: no new files.actions.lockis machine-generated ("Do not edit by hand") and carries no header, as before.continue-on-error.Notes for reviewers
Validate Hypatia Baselinefailure "is not fixed by a relock". That was wrong.lib/rules/workflow_audit.ex:317-333treats any ref the lock vouches for as pinned (ActionsLock.pinned?), and fix(ci): clear hypatia's red checks (try_update, Dependabot lock entries, rustls, baseline) #908 measured exactly that: 9 ×unpinned_actioncleared with a relock alone. CI on this head confirms it: the Baseline check passes with no inline SHA pins and no baseline re-ACK. The same comment records why inline SHA-pinning would be a regression here: on 2026-08-07, inline-pinning 40 refs put 14 workflows intostartup_failure.Closes #914is earned. All 5 workflows that died at startup now start on this head. What they found once running is tracked in security-policy.yml: 3 pre-existing failures surfaced once the workflow starts (deferred from #915) #916, not here.🤖 Generated with Claude Code
https://claude.ai/code/session_015bTuGfwCcvjrmNFejydTML