Repository navigation
ci(estate-audit): bound the job at 10 minutes (Hypatia missing_timeout_minutes) - #120
Conversation
Hypatia workflow_audit (code-scanning alert 168, missing_timeout_minutes) flagged that estate-audit inherits the 6-hour default, so a stuck fetch or runner hang can burn budget. The job runs two quick gates; 10 minutes is ample. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X3hgXxWm6umMgZkjYyHnnm
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (7)
🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe ChangesEstate audit workflow
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This bounds the estate-audit CI job at 10 minutes instead of GitHub's six-hour default. No concrete problem was found. If the audit normally takes longer than 10 minutes, the job will be cancelled, so confirm with a CI run. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. I’m a rabbit, hopping by, Comment |
Summary
Hypatia's workflow audit opened a code-scanning thread on #119 (alert 168,
missing_timeout_minutes): theestate-auditjob inmain-estate-audit.ymldeclares notimeout-minutes, so it inherits GitHub's 6-hour default. A stuck fetch or a runner hang could burn that much budget. This PR bounds the job at 10 minutes. The job runs two quick gates, so 10 minutes is ample.The fix was made on #119's branch after #119 had already merged at
a87fa8a, so it never reachedmain. This PR carries it ontomain(10819d6) by itself.Type of change
timeout-minutesline.📌 New pins
Head SHA:
a42c00647083691f902d7897b6ca90e9617f2460None. No
uses:ref,actions.lockentry, lockfile or container digest is added or changed.How has this been verified?
git diff origin/main --stat: one file, one line added (timeout-minutes: 10underestate-audit).actionlint .github/workflows/main-estate-audit.yml: rc=0.main.Checklist
git commit -S):a42c006showsG.Notes for reviewers
fix/redci-cleanup(atec166e9) was re-created by mistake after fix(ci): cicd-suite 4c772eb2, rust-ci pin, Justfile and workflow hygiene #119's merge and can be deleted. This PR supersedes it.🤖 Generated with Claude Code
https://claude.ai/code/session_01X3hgXxWm6umMgZkjYyHnnm