Skip to content

Retain typing metadata and build inputs in source distributions - #132

Open
ketpatil77 wants to merge 1 commit into
hdwallet-io:masterfrom
ketpatil77:fix/downstream-package-support
Open

ketpatil77 wants to merge 1 commit into
hdwallet-io:masterfrom
ketpatil77:fix/downstream-package-support

Conversation

@ketpatil77

Copy link
Copy Markdown

Fixes #121.

Add hdwallet/py.typed and include it in the manifest. Source-to-wheel validation also exposed missing setup inputs: setup.py reads requirements/cli.txt, requirements/docs.txt and requirements/tests.txt, but the archive omits them. Include those three files so the source archive can actually rebuild a wheel.

Validation on Windows / Python 3.11.9:

  • Original source and wheel artifacts lack hdwallet/py.typed. Verified the corrected sdist, direct wheel, and wheel rebuilt from the extracted sdist all retain the empty marker at the correct package path. In separate installed-wheel environments outside the checkout, mypy 2.4.0 reports import-untyped before the fix; the valid consumer probe passes after the fix and a deliberately invalid consumer is rejected. These focused probes use follow_imports=silent and suppress missing dependency imports; they do not assert that the entire library is strict-type-check clean.
  • Both direct and source-rebuilt wheels retain the marker. The original round-trip failed with FileNotFoundError for requirements/cli.txt; the corrected source archive rebuilds successfully. Focused installed-consumer typing probes pass. Cryptographic runtime tests, full dependency matrix, lint, and whole-library type checks were not run.
  • git diff --cached --check passes.

Runtime implementations and test expectations are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing py.typed

1 participant