Skip to content

Fix relative_progress with new hashcat release #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MelvinFrederiks wants to merge 6 commits into
base: master
Choose a base branch
from
+10 −1
Open

Fix relative_progress with new hashcat release #74

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af7f2ea
Add a skip field in HashcatStatus
MelvinFrederiks Aug 31, 2026
ed0efb6
Remove absolute= kwarg, but only set skip if version if after 7.1.2
MelvinFrederiks Aug 31, 2026
024be0e
Fix version tuple creation
MelvinFrederiks Aug 31, 2026
30212ad
Remove github link
MelvinFrederiks Aug 31, 2026
41b6a95
Revert changes to getters: Instead adapt calculation of relative_prog…
MelvinFrederiks Sep 2, 2026
5477d83
Refine version cutoff for relative progress calculation determination
MelvinFrederiks Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion htpclient/hashcat_cracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,10 @@ def run_loop(self, proc, chunk, task):
else:
identifier, line = item
if identifier == 'OUT':
# "7.1.2" -> (7,1,2)
# "7.1.2-546-gc885beef" -> (7,1,2,546)
version_list = self.version_string.replace('-', '.').split('.')[:4] # Chop off anything past the fourth field (for example commit hash)
version_tuple = tuple(int(s) for s in version_list)
status = HashcatStatus(line.decode())
if status.is_valid():
self.statusCount += 1
Expand Down Expand Up @@ -344,7 +348,12 @@ def run_loop(self, proc, chunk, task):
# we need to calculate the chunk start, because progress does not start at 0 for a chunk
chunk_start = int(status.get_progress_total() / (chunk['skip'] + chunk['length']) * chunk['skip'])
if total > 0:
relative_progress = int((status.get_progress() - chunk_start) / float(total - chunk_start) * 10000)
if version_tuple >= (7, 1, 2, 546):
relative_progress = int(status.get_progress() / total * 10000)
else:
# before hashcat 7.1.2-546, the PROGRESS fields included the skip value.
# Adjust for this offset
relative_progress = int((status.get_progress() - chunk_start) / float(total - chunk_start) * 10000)
else: # this is the case when we cannot say anything about the progress
relative_progress = 0
speed = status.get_speed()
Expand Down