Keep log level filtering when the prefix uses brackets - #19
Open
BetterAndBetterII wants to merge 1 commit into
Open
Keep log level filtering when the prefix uses brackets#19BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
LevelFilter treated the first bracketed token as the level, so a log.SetPrefix that also used brackets disabled filtering. Scan later tokens and only treat a configured level as the filter level. Fixes hashicorp#8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LevelFilter.Checktreated the first[...]token on a line as the log level. Whenlog.SetPrefixalso used square brackets, that prefix was mistaken for a level name, so filtering stopped working and every message passed through.Scan later
[...]tokens and only treat a token as the level when it matches a configuredLevelsentry.Test plan
go test -count=1 .SetPrefixwith brackets + DEBUG/WARN/ERROR)Fixes #8