Repository navigation
refactor: type render methods as string (#832) - #975
Merged
Merged
Conversation
- Change render methods from returning any to string - Change internal generator methods from any to unknown - Change evalValue methods from any to unknown - Add suppressImplicitAnyIndexErrors to rollup config This improves TypeScript support for users who depend on render method return types. Fixes #832
Co-authored-by: Cursor <cursoragent@cursor.com>
Coverage Report for CI Build 37325643328Warning No base build found for commit Coverage: 99.528%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Co-authored-by: Cursor <cursoragent@cursor.com>
This reverts commit 86bedf2.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
harttle
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
harttle
changed the title
harttle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render,renderSync,parseAndRender,parseAndRenderSync,renderFile, andrenderFileSyncare typed asstring/Promise<string>.emitter.buffer, a string. This only replaces theanyreturn type.Fixes #832
Test plan
npm run buildnpm run lint