Skip to content

Document the port timeout option in the README - #32

Merged
glopesdev merged 1 commit into
mainfrom
readme-add-timeout
Aug 31, 2026
Merged

Document the port timeout option in the README#32
glopesdev merged 1 commit into
mainfrom
readme-add-timeout

Conversation

@banchan86

Copy link
Copy Markdown
Contributor

I only discovered this option recently (I was terminating the process manually before), and it is a little bit buried unless people bring up the --help, so briefly mentioning it in the README might help surface this option.

I only discovered this option recently (was terminating the process manually before) and it is a little bit buried unless people bring up the --help, so briefly mentioning in the README might help surface this option.

@glopesdev glopesdev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good catch. --timeout really is only visible through --help at the moment, and the README is the right place to name it.

Approving as it stands. Your change did prompt a follow-up, because it made clear that the underlying problem is the default rather than the documentation: omitting the option waits indefinitely, and the option is currently applied only to the first read. I have filed that as #35, so we will probably revisit this README line once the default exists, and make step 5 go back to the short form.

@glopesdev glopesdev changed the title Update README with timeout parameter for checking serial port Document the port timeout option in the README Aug 31, 2026
@glopesdev
glopesdev merged commit 7b342c2 into main Aug 31, 2026
17 checks passed
@glopesdev
glopesdev deleted the readme-add-timeout branch August 31, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants