Repository navigation
fix(core): skip unreadable skills instead of failing the machine scan - #469
Merged
Merged
Conversation
readAdapterSkills read each SKILL.md and its capsule with no catch, so one
refused file aborted importMachine. The desktop onboarding scan hit this on a
SKILL.md symlinked outside the Tauri fs scope ("forbidden path"), and an
oversized skill capsule throws the same way. Each such skill is now reported
in the fragment's skipped list (surfaced in findings) and the scan continues.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
siracusa5
enabled auto-merge (squash)
November 17, 2026 00:52
The AC-21 test read the palette's Preview option synchronously after the directory check rendered; under a loaded run the command registers a tick later and the query failed. vi.clearAllMocks also leaves queued mockResolvedValueOnce values in place, so that one failure fed stale compile results to the next four tests. Await the option and reset the compile and detectPlatforms mocks in beforeEach. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The desktop first-run scan failed with:
forbidden path: ~/.claude/skills/capture-session/SKILL.md, maybe it is not allowed on the scope for 'allow-read-text-file' permission in your capability fileThat SKILL.md is a symlink into a directory outside the Tauri fs scope.
readAdapterSkills(packages/core/src/import/read-skills.ts) read each SKILL.md and its capsule with no catch, so one refused file rejectedimportMachineand the onboarding scan showed "The machine scan did not finish".Fix
Catch per skill. A skill whose SKILL.md or capsule can't be read is recorded in the fragment's existing
skippedlist (it reachesfindings.adapters[].skipped) and the scan continues. This also covers an oversized capsule, which threw the same way.The fs scope is unchanged. Widening it to follow symlinks out of
~/.claudeis a security call left for a separate decision.Verification
packages/core/__tests__/import-unreadable-skill.test.ts: a reader that throws "forbidden path" for one SKILL.md; the other skills survive and the blocked one is reported as skipped, both inreadAdapterSkillsand throughimportMachine. Fails on main, passes here.tscclean. desktop: 1184 tests pass,tscclean.importMachineagainst a real home directory with a provider that emulates the Tauri read scope (realpath outside the capability roots throws, symlinks listed as Tauri lists them). On main it throws the exact error above; on this branch it completes, with the symlinked skill and one oversized.codexskill capsule listed as skipped.Not checked: clicking through onboarding in the running Tauri app.
🤖 Generated with Claude Code