Repository navigation
feat(desktop): Phase 3 profile, share, team baseline and install-to - #463
Merged
Merged
Conversation
…ompt buildProfileShare runs the capture sanitizer, then a stricter share-only pass over every string (URL userinfo, query and fragment params anywhere, KEY=value, header text, values after secret flags, JSON in strings, Stripe-style keys). buildProfilePrompt has the recipient's agent save the file, set its variables, and install and compile from the project the user names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
recommend() now takes its baseline gaps from it, so the desktop column and harness-kit status --baseline share one matching rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The page supplies only the text, a name stem and the kind; the path always comes from the user's pick. Size-capped, written atomically. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Profile: Scan this machine with review before writing; editor and editable panel side by side (comment-preserving YAML patches); Compile as a tab. - Share sheet: harness.yaml and agent prompt, Copy and Save file. - Machine: Team baseline column from the project's committed harness.yaml. - Marketplace: Install to… with surface picker, CLI command and prompt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… shared text
Adversarial review found secrets surviving (inline --github-token=, header
text in prose, KEY=value with ; or &, strings holding a ${HARNESS_} reference,
github_pat_/npm_/glpat-/AIza keys, webhook path secrets, numbers and lists
under sensitive keys) and false positives (MAX_TOKENS=4096, git@ sources,
--key-file). Names are now judged by their last word, values by shape; each
secret gets its own variable; the prompt keeps every shared string inside the
data fence and states the data rule first.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…patches survive odd input - Save sends the digest of the text the buffer was synced with, so a disk version still waiting behind the dirty-buffer notice is refused, not lost. - Share computes in a try/catch inside its own boundary; non-mapping roots disable it. - Panel patches re-point list indexes at the current buffer or refuse. - Discard clears the panel debounce; a failed Reload clears forceLoad; a second Cmd+S is ignored while saving. - YAML patches keep CRLF, skip block-scalar text when inferring style, refuse a scalar root, and keep the header comment when the root empties. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The draft lives in a store that outlives the page, so going to another page and back restores it; a disk change in between shows the existing notice and Save keeps its conflict check. The Profile sidebar item shows a dot while a draft exists. Also steadies the double-save test, which raced the digest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 3 of the desktop UX spec (
specs/ux-consolidation/spec.md, AC-22..AC-27).yamlDocument API, so comments and indentation survive. A wrong-shaped section shows a note instead of crashing the page./harness/syncredirects. Switching tabs keeps unsaved edits.buildProfileShare/buildProfilePrompt: the capture sanitizer plus a stricter share-only pass. New Rustsave_share_fileopens the Save dialog itself, so the page never names a path.baselineCoverage;recommend()uses it, so the CLI'sstatus --baselineand the column agree. "Missing here" rows offercd <project> && … install && … compile.Review round
An independent review found Share leaking secrets in common shapes (URL userinfo/fragments, URLs outside
urlfields,KEY=valueargs,--github-token,--header, JSON in args,sk_live_keys) and the Profile page crashing on wrong-shaped YAML. All fixed with tests; each share rule and desktop fix was mutation-checked (disable it, a test fails).Adversarial review round
Two critics (Sonnet, Haiku) attacked the fix-round code. Verified and fixed:
Share scrubber rewritten as a per-token scanner: names judged by their last word (
GITHUB_TOKENyes,MAX_TOKENSno), values by shape. 23 further leak shapes and 10 false positives are now tests; each of its 22 rules is mutation-checked.The agent prompt keeps every shared string (name, descriptions) inside the data fence and states the data rule first.
Save after a "re-read from disk" notice no longer overwrites the other writer's change.
Share, panel patches and YAML patching survive odd input (non-mapping roots,
env: foo, CRLF, block scalars, stale list indexes).Leaving Profile with unsaved edits no longer loses them: the draft is kept in memory and restored on return, with a dot on the Profile sidebar item. Quitting the app still loses an unsaved draft.
Not in this PR
~/.harness/harness.yaml, desktop~/.claude/harness.yaml.${NAME}references compile unchanged; Cursor and Copilot expect${env:NAME}.Verification
Compare your output against
specs/ux-consolidation/spec.mdand list any requirements not addressed.🤖 Generated with Claude Code