Skip to content

feat(desktop): Phase 2c steps 2-4, one answer per question, tests that see production, access and docs - #462

Merged
siracusa5 merged 16 commits into
mainfrom
ux/p2c-steps-2-4
Nov 13, 2026
Merged

siracusa5 merged 16 commits into
mainfrom
ux/p2c-steps-2-4

Conversation

@siracusa5

Copy link
Copy Markdown
Collaborator

Phase 2c steps 2 to 4 (spec specs/ux-consolidation/spec.md AC-55 to AC-61, cards 2c.8 to 2c.18). Step 1 shipped in v0.13.0.

One answer per question (AC-55 to AC-59)

  • One harness.yaml. The personal profile is ~/.claude/harness.yaml; the selected project's committed harness.yaml is its team baseline. Drift, Profile and Compile read the same files.
    • Drift tells apart no file, unreadable, never compiled and clean.
    • Profile follows the title-bar project and shows the project file read-only.
    • Compile uses the project's file, or the personal profile when the project has none.
    • If ~/harness.yaml exists and the new path doesn't, Drift and Profile say where the file moved.
  • Onboarding and "Generate" build harness.yaml from the same machine inventory the grid shows (core importFromInventory). Secrets become ${NAME} references, and Compile refuses a literal <secret>. The retired ~/.claude/mcp.json reader is removed.
  • Machine grid.
    • Clicking a cell opens the drawer with that surface as the target.
    • "+ copy" appears only where the drawer can apply it.
    • Surfaces that aren't installed are hidden behind "Show all N".
    • Instructions are one row per scope. They compare and copy as whole files without marker lines, so a copy closes the gap and never nests blocks.
  • Remote MCP servers. An entry with a url reads as a remote server.

Tests that see production (AC-60)

  • IPC contract. 71 shared fixtures, checked from both sides: what tauri.ts sends and what the Rust command signatures accept.
  • Capability checks. The coverage script now checks plugin fs/dialog/shell imports, and a smoke test runs against the real ACL.
  • CI. A macOS CI job, plus a nightly that launches the built app. It confirms the launch but can't drive the UI, because there is no macOS WebKit driver.

Access, truth and docs (AC-61)

  • Accessibility.
    • Text tokens meet WCAG AA in both themes, and a test checks each ratio.
    • Modals trap focus and return it.
    • The sidebar marks the current section on child routes.
    • Plugin rows and the context menu work from the keyboard.
    • The command palette is a listbox.
    • One notification region is always mounted.
  • Truth sweep.
    • Copy matches what the app does.
    • The vocabulary is Copy, Compile and Drift, with no user-facing "sync".
    • Ledger internals sit behind Settings › Labs.
  • Changes list with Undo (new Rust). Undo takes only a transaction id. It checks the manifest path and every file against the declared stores, then writes through the transaction engine, so a file changed since the copy refuses. Drawer copies are logged as structured audit entries, only for transactions this app session applied.
  • Docs. The site, README and DESIGN.md describe the current app, and false code comments are fixed.

Ask-first changes you approved

  • Core:
    • importFromInventory (AC-56)
    • remote MCP reading (AC-58)
    • instruction rows keyed by scope (AC-57)
  • src-tauri: the Changes list with Undo and the copy audit.

Known and left alone

  • Profile paths differ. The CLI's personal profile is ~/.harness/harness.yaml; the desktop uses ~/.claude/harness.yaml. Lining them up is a CLI change, so it waits on John.
  • Secret references. ${NAME} references compile through unchanged. Claude Code expands them; Cursor and Copilot expect ${env:NAME}, as before this branch.
  • Audit log. A compromised webview can still produce audit entries for transactions it really applied through the normal command.
  • Rare edges:
    • A multi-file Undo that hits an I/O error halfway stays half done.
    • A file with two sync blocks updates only the first.
  • pnpm install:desktop and a real-app click-through were not run. A browser check of the Machine fixture at 1024px and 1440px was.

Verification

  • Tests: core 914, CLI 151, desktop 1,047, Rust 274 plus a 5-test capability smoke.
  • Static checks: tsc and clippy (-D warnings) are clean, and check:capabilities passes.
  • Mutation checks: every new behavior and every fix was checked.
  • Reviews: an opus review of the whole branch, then a re-review of the fix commits. All confirmed findings are fixed except the items listed above.

🤖 Generated with Claude Code

siracusa5 and others added 16 commits November 11, 2026 20:44
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es that aren't installed (AC-57, AC-59)

+ copy shows only where the drawer can apply (MCP servers, skills, instructions). Not-installed surfaces are hidden by default behind Show all N.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…om the machine inventory (AC-55, AC-56)

Drift reads ~/.claude/harness.yaml for the personal scope and the project's committed harness.yaml for the project, and tells no-file, unreadable, never-compiled and clean apart. Onboarding and Generate take MCP servers and permissions from the same inventory the Machine grid shows (core importFromInventory). Removes the ~/harness.yaml fallback and the scan_claude_config command that read the retired ~/.claude/mcp.json.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… coverage; macOS CI and nightly app launch (AC-60)

69 shared fixtures checked from both sides (tauri.ts payloads and Rust command signatures), plugin fs/dialog/shell imports checked against the capability, a capability smoke test on the real ACL, a macOS CI job, and a nightly that launches the built app.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…re one row per scope (AC-55, AC-57)

Profile shows the project's committed harness.yaml read-only as the team baseline; Compile compiles it, or the personal profile when the project has none. Core's machine scan keys instructions on scope, so an instructions copy leaves no gap on rescan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…enus and current-route marking (AC-61)

Raises subtle, placeholder, primary-fill and status-text tokens to WCAG AA in both themes (each ratio tested). Modals trap and return focus; the sidebar marks the current section on child routes; plugin rows and the context menu work from the keyboard; the command palette is a listbox; one always-mounted notification region.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ary; AA text tokens everywhere

Settings no longer promises save confirmations the editors don't make; 'Explore read-only' is 'Skip for now'; no user-facing 'sync'; ledger internals move behind Settings > Labs; remaining danger/success/warning text uses the -text tokens; Machine grid labels truncate with a tooltip instead of clipping.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… code comments

Desktop mock and home page match the current nav (Machine, Profile, Claude Code, Marketplace, Labs); new Machine docs page; Observatory is Usage; Parity points at Machine; DESIGN.md tokens, legend, tab and drawer sections updated; removes claims about a lint and pages that no longer exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settings > Activity lists recent changes from the rollback ledger. Undo runs in Rust: it takes only a transaction id, validates the manifest path and every file against the declared stores, and writes through the transaction engine with the post-change digest, so an edited file refuses. Drawer copies are recorded as structured machine_copy audit entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lidate surfaces; no ledger overwrites

record_transaction writes the machine_copy audit entry and ledger row only after the pinned manifest reads committed and its folder matches the id; copiedFrom and surfaces are checked against the registry ids (a test keeps the Rust list in step with core); surfaces are capped; an existing transaction id can't be rewritten with a different payload.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…erences; note the moved harness.yaml

Instruction files digest as their harness:sync block when they have one, and copies write a fixed per-scope block, so a copied row reads as the same and copying back can't nest. Generate writes secret env and header values as ${NAME} references and compile refuses a literal <secret>. Drift and Profile say when ~/harness.yaml exists but ~/.claude/harness.yaml doesn't. Grid header badges sit under the label so it stays readable at 1024px.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… only the harness block

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…log a copy once

apply_surface_transaction remembers the ids it committed; record_transaction refuses any other id, so a hand-written manifest can no longer produce an audit entry. An identical replay inserts nothing and logs nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… markers

Prose outside a harness:sync block now counts, so edits to it show as drift and a copy carries it. A target with its own text reads as differs and asks before the block is updated; the drawer and the agent prompt say which case applies and never call the instructions missing when the target has its own file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@siracusa5
siracusa5 merged commit e9b0dad into main Nov 13, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant