Repository navigation
fix(desktop): Phase 2c step 1, stop data loss and make the webview trust boundary real - #452
Merged
Merged
Conversation
…ed with a backup (AC-51) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…th, by full key (AC-48) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…omically (AC-53) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eychain secrets never on argv (AC-49, AC-54) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rename/remove; dialog-bound project scope (AC-52) Removes shell execute/spawn/stdin/kill and the unused worktree commands. lstat and mkdir are granted at the existing scope; rename and remove go through Rust commands that keep paths inside declared roots. Project dirs saved by older builds must be re-picked once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d up; zip entries capped (AC-50) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a native dialog, clean refused temp files Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- guarded rename only moves a temp file onto its own store, or within one granted root; remove deletes only temp files and backups, and moves a store to ~/.harness/backups/quarantine instead of deleting it - drop fs:allow-write-text-file; the engine's temp writes go through guarded_write_file - plugin import takes a native-dialog pick or an OS drop, not a webview path - uninstall requires name@marketplace, deletes only cache/<mkt>/<name>, and rewrites the record before deleting anything - presets confirm the exact deny list shown; permissions, env config and installed_plugins.json writes are digest-checked, atomic and backed up - user-scope writes follow a symlinked dotfile to its target - claude_md refuses . and .. before creating directories Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ups out of dotfiles - inside a granted project root, guarded write/rename/remove act only on the temp file of a declared project store (new projectWriteScope in core, generated into write-scope.json); any .git component is refused - quarantined files can't be overwritten by write or rename - write_user_file backups go to ~/.harness/backups/user/<stamp>/, never beside a symlink target in a dotfiles repo Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d_permissions shapes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2c step 1 (spec
specs/ux-consolidation/spec.mdAC-48..AC-54, cards 2c.1–2c.7). This is the safety work to land before v0.13.0, the first stable release with the Machine view.What changes
name@marketplace, deletes onlycache/<marketplace>/<name>, and rewritesinstalled_plugins.jsonbefore deleting anything.~/.harness/backups/user/<stamp>/. Covers CLAUDE.md, harness.yaml, plugin files, settings.json, env config, installed_plugins.json and custom profiles. A symlinked dotfile is followed to its target; the backup never lands in the dotfiles repo.fs:allow-write-text-file, and the unused worktree commands.lstatandmkdirare granted at the existing scope. These calls were made but not granted, so Drift Fix failed in the real app.guarded_*Rust commands. In home they act only on a declared store's own temp file. In a project they act only on declared project stores, and never in.git. "Remove" of a store moves it to~/.harness/backups/quarantine/.Needs your eye
packages/coregainsprojectWriteScope(), which is additive and generated intowrite-scope.json. The spec lists core as ask-first. It sits inside the approved Step 1 work, but it's flagged here.Verification
--maxWorkers=2; the default parallel run is timing-flaky on this machine, including a MachinePage test this branch doesn't touch). tsc clean.cargo test --lib239 passed, clippy-D warningsclean,check:capabilitiesOK.tauri devwith no capability errors. Native dialogs and drag-drop were not clicked through.🤖 Generated with Claude Code