Repository navigation
feat(app): remove the deprecated research surfaces (#1818) - #1819
Merged
aarontrowbridge merged 1 commit intoOct 17, 2026
Merged
aarontrowbridge merged 1 commit into
aarontrowbridge merged 1 commit into
Conversation
… not wiring The system/formulation/run/pulse/device research UI was deprecated months ago; it ships no longer. The strip (flag-off where shared files carry live neighbors, deletion where dead-from-everywhere): - ui package: entity-rail/entity-view/formulation-view/system-view/run-view/ device-view/calibration-view/system-render/receipt-currency + their shims deleted; problem.ts reduced to the live receipt exports; card.tsx stripped of the entity-view clickability; home-cards stripped of the Jump back in / Now solving / Pulse-bank trio; the refetch-edge predicates extracted live. - app package: home.tsx loses the four deprecated fetches (problems, problem?slug=, run-status, run-series-for-live-run), the resume/live-run polls and callbacks; session-new-view's resume chip gone; the message- timeline rail mount + entity dialog deleted (the live warrants/approve/ run-series transports preserved through headless bridge registrations); device-inspector deleted. - engine server: the widget built-ins emptied (jump-back-in gone). - the widget allowlist tightened: the deprecated routes left the SECURITY seam with their surfaces — a sandboxed widget can no longer fetch them. Verification: the absence test 15/15 (red-first against the pristine tree); ui suite 435/0; app suite 1710 pass with the failure set BYTE-IDENTICAL to the baseline (zero new); typecheck back to the known set (one broken shim export fixed); the built bundle greps clean (Now solving / problems / problem? / run-status all absent); drift PASS. The extension-side jump-back-in built-in is flagged for its own follow-up (out of this slice's scope, recorded); the live receipt vocabulary (formulation/pulse/device strings in chipText + the Pulse Inspector tab) stays by design.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1818. The user's #1 daily pain: a UI deprecated months ago finally ships no longer.
REMOVAL, not wiring: the surface graph (entity-rail through device-view, the Now solving trio, the resume/live-run machinery, the timeline's rail mount, the widget built-ins) is stripped or deleted per reachability; the LIVE neighbors (composer, session list + chips, inbox, notifications, harness control, receipt vocabulary, the Pulse Inspector tab) render identically. The widget allowlist tightened with the surfaces — the deprecated routes left the security seam too.
The rebuilt bundle (index-CCzFVXc1) greps CLEAN: 'Now solving', /amicode/problems, /amicode/problem?, /amicode/run-status all absent. The absence test (red-first) pins it; app suite 1710 pass, failure set byte-identical to baseline; ui 435/0; drift PASS.
The dist swap + the live probe gate run as the ritual (HITL). The extension-side jump-back-in built-in + the golden fixture regen is recorded as its own follow-up.