Repository navigation
feat(blocklist): add dyknow amazon s3 domain to blocklist - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The added entry matches the requested domain and follows the existing blocklist syntax and section placement conventions.
Pull request overview
Adds a DyKnow-related Amazon S3 bucket hostname to the existing DyKnow section of blocklist.txt, aligning with Issue #5’s requested domain.
Changes:
- Added
||dyknow-data-prd.s3.amazonaws.com^under the! DyKnowheader. - Removed an extraneous trailing blank line at the end of
blocklist.txt.
File summaries
| File | Description |
|---|---|
| blocklist.txt | Adds the DyKnow S3 bucket domain to the DyKnow vendor section and cleans up the file ending. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (Blocklist)
1. Type of Change:
What does this PR do? (Check one)
2. Related Issue:
Does this fix an existing issue? Please link it here (e.g., "Closes #12").
3. Summary of Changes:
Briefly explain what you changed and why. (e.g., "Added 10 new telemetry domains for GoGuardian," "Removed canvas.instructure.com because it broke logins")
4. Verification & Testing:
How did you verify these changes?
||domain.com^) is correct.5. Placement:
Where did you put the new domains?
! Lightspeed).Final Checklist: