Skip to content

feat(blocklist): add dyknow amazon s3 domain to blocklist - #6

Merged
nota9x merged 1 commit into
mainfrom
add-dyknow-domain
Sep 3, 2026
Merged

nota9x merged 1 commit into
mainfrom
add-dyknow-domain

Conversation

@nota9x

@nota9x nota9x commented Sep 3, 2026

Copy link
Copy Markdown
Member

Pull Request (Blocklist)

1. Type of Change:
What does this PR do? (Check one)

  • Add new domains to the blocklist
  • Remove domains (False Positive fix)
  • Documentation / Maintenance update

2. Related Issue:
Does this fix an existing issue? Please link it here (e.g., "Closes #12").

Closes #5

3. Summary of Changes:
Briefly explain what you changed and why. (e.g., "Added 10 new telemetry domains for GoGuardian," "Removed canvas.instructure.com because it broke logins")

Added DyKnow Amazon s3 bucket domain

4. Verification & Testing:
How did you verify these changes?

  • I have verified that these domains belong to the target service.
  • I have checked that the Adblock Plus syntax (||domain.com^) is correct.
  • (If removing) I confirmed that unblocking this restores the broken functionality.

5. Placement:
Where did you put the new domains?

  • Under the correct Vendor Header (e.g., ! Lightspeed).
  • Created a new header for a new service.

Final Checklist:

Copilot AI lite review requested due to automatic review settings September 3, 2026 19:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The added entry matches the requested domain and follows the existing blocklist syntax and section placement conventions.

Pull request overview

Adds a DyKnow-related Amazon S3 bucket hostname to the existing DyKnow section of blocklist.txt, aligning with Issue #5’s requested domain.

Changes:

  • Added ||dyknow-data-prd.s3.amazonaws.com^ under the ! DyKnow header.
  • Removed an extraneous trailing blank line at the end of blocklist.txt.
File summaries
File Description
blocklist.txt Adds the DyKnow S3 bucket domain to the DyKnow vendor section and cleans up the file ending.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nota9x
nota9x merged commit 9b1ec47 into main Sep 3, 2026
2 checks passed
@nota9x
nota9x deleted the add-dyknow-domain branch September 3, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ADD] - dyknow-data-prd.s3.amazonaws.com

2 participants