chore(deps): upgrade grpc-java to 1.83.1 and jackson to 2.18.9 - #144
Open
halibobo1205 wants to merge 2 commits into
Open
chore(deps): upgrade grpc-java to 1.83.1 and jackson to 2.18.9#144halibobo1205 wants to merge 2 commits into
halibobo1205 wants to merge 2 commits into
Conversation
1. bump grpcVersion to 1.83.1 to pick up the upstream fix for grpc/grpc-java#12930 (PR grpc/grpc-java#12942), which enforces connection.remote().maxActiveStreams(maxStreams) at handler startup 2. drop GrpcNettyMaxConcurrentStreamsLimiter, the local protocol-negotiator shim that applied the same limit while 1.83.0 left the remote endpoint unbounded until the client acknowledged SETTINGS 3. set maxConcurrentCallsPerConnection directly on NettyServerBuilder in RpcService, as it was done before the shim 4. move shouldIgnoreClientMaxHeaderListSizeOnServer from the deleted shim test into NettyHttp2HeaderSecurityTest, since it guards netty CVE-2026-50560 rather than the shim 5. update the io.grpc checksums in gradle/verification-metadata.xml 6. keep RpcServiceHttp2SecurityTest as the regression guard: it fails on 1.83.0 without the shim and passes on 1.83.1
1. bump jackson-databind in :common to 2.18.9 and let jackson-annotations, jackson-core and jackson-bom follow it transitively 2. update the jackson checksums in gradle/verification-metadata.xml 3. leave jackson-parent at 2.18.4, which jackson-bom 2.18.9 still points at
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
What does this PR do?
grpc-javafrom 1.83.0 to 1.83.1, removesGrpcNettyMaxConcurrentStreamsLimiter.jackson-databindfrom 2.18.6 to 2.18.9.Why are these changes required?
The shim carried an explicit
// TODO: Remove this shim after https://github.com/grpc/grpc-java/issues/12930 is fixed.That issue is now fixed upstream by grpc/grpc-java#12933, backported in grpc/grpc-java#12942 and released in [v1.83.1](https://github.com/grpc/grpc-java/releases/tag/v1.83.1).The Jackson bump is a routine patch-level upgrade on the 2.18.x line.
This PR has been tested by:
Follow up
Extra details
CodeAnt-AI Description
Update gRPC and Jackson dependencies while securing HTTP/2 connection handling
What Changed
Impact
✅ Reliable concurrent-call limits from connection startup✅ Fewer HTTP/2 response failures caused by hostile client settings✅ Updated Jackson security and stability fixes💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.