Repository navigation
Conversation
smais-max
force-pushed
the
fix/testsuite-npe-and-headless-firefox
branch
2 times, most recently
from
October 27, 2026 07:23
763af98 to
8060653
Compare
TestsuiteEnvironmentUtils.getResourceAsStream() returns null when testsuite.properties is missing, causing NPE that bypasses fallback logic. Added null-check so it falls through to system property and environment variable lookups. Also added System.getenv() as fallback for JBOSS_HOME resolution. Replaced browser.maximize() with fixed setSize(1920x1080) before navigation. maximizeWindow causes 1500+ Marionette TimedPromise timeouts (5s each) in Xvnc CI environments, leading to cascade hal-root-container failures. setSize bypasses the window manager entirely.
smais-max
force-pushed
the
fix/testsuite-npe-and-headless-firefox
branch
from
October 29, 2026 09:46
30455a1 to
8060653
Compare
When hal-root-container is not present within 20s, refresh the page and wait again before failing. This prevents a single transient load failure from cascading into 100+ subsequent test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestsuiteEnvironmentUtils.getResourceAsStream() returns null when
testsuite.properties is missing, causing NPE that bypasses fallback
logic. Added null-check so it falls through to system property and
environment variable lookups. Also added System.getenv() as fallback
for JBOSS_HOME resolution.
Enabled headless Firefox in arquillian.xml to eliminate Marionette
maximizeWindow timeouts in CI (Xvnc) environments.