Skip to content

Fix NPE in TestsuiteEnvironmentUtils and enable headless Firefox - #228

Draft
smais-max wants to merge 2 commits into
hal:73xfrom
smais-max:fix/testsuite-npe-and-headless-firefox
Draft

smais-max wants to merge 2 commits into
hal:73xfrom
smais-max:fix/testsuite-npe-and-headless-firefox

Conversation

@smais-max

Copy link
Copy Markdown

TestsuiteEnvironmentUtils.getResourceAsStream() returns null when
testsuite.properties is missing, causing NPE that bypasses fallback
logic. Added null-check so it falls through to system property and
environment variable lookups. Also added System.getenv() as fallback
for JBOSS_HOME resolution.

Enabled headless Firefox in arquillian.xml to eliminate Marionette
maximizeWindow timeouts in CI (Xvnc) environments.

@smais-max
smais-max force-pushed the fix/testsuite-npe-and-headless-firefox branch 2 times, most recently from 763af98 to 8060653 Compare October 27, 2026 07:23
  TestsuiteEnvironmentUtils.getResourceAsStream() returns null when
  testsuite.properties is missing, causing NPE that bypasses fallback
  logic. Added null-check so it falls through to system property and
  environment variable lookups. Also added System.getenv() as fallback
  for JBOSS_HOME resolution.

  Replaced browser.maximize() with fixed setSize(1920x1080)
  before navigation. maximizeWindow causes 1500+ Marionette TimedPromise
  timeouts (5s each) in Xvnc CI environments, leading to cascade
  hal-root-container failures. setSize bypasses the window manager
  entirely.
@smais-max
smais-max force-pushed the fix/testsuite-npe-and-headless-firefox branch from 30455a1 to 8060653 Compare October 29, 2026 09:46
  When hal-root-container is not present within 20s, refresh the page
  and wait again before failing. This prevents a single transient load
  failure from cascading into 100+ subsequent test failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant