Repository navigation
fix(crypto): only consider packages as generating crypto assets - #2899
Merged
Merged
Conversation
Nodes other than packages may carry a PURL and generate (`provides`) a crypto asset, e.g. a CycloneDX machine-learning model. Those have no `sbom_package` row, yet were returned by the `crypto` filter of the PURL listing, and counted in the `packages_count` of crypto algorithms. Require the left node of the `Generates` relationship to have a matching `sbom_package` row in both places.
Contributor
Reviewer's GuideImplementationRequire a matching
TestsAdd coverage showing that a non-package model which provides a crypto asset is excluded from package counts and PURL crypto-filter results.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodes other than packages may carry a PURL and generate (
provides) a crypto asset, e.g. a CycloneDX machine-learning model. Those have nosbom_packagerow, yet were returned by thecryptofilter of the PURL listing, and counted in thepackages_countof crypto algorithms.Require the left node of the
Generatesrelationship to have a matchingsbom_packagerow in both places.Summary by Sourcery
Ensure crypto relationships only treat actual SBOM packages as generating crypto assets.
Bug Fixes:
sbom_packagerecord, excluding non-package nodes such as machine-learning models.Tests: