Skip to content

fix(crypto): only consider packages as generating crypto assets - #2899

Merged
gildub merged 1 commit into
guacsec:mainfrom
gildub:fix-crypto-sbom_package
Nov 19, 2026
Merged

gildub merged 1 commit into
guacsec:mainfrom
gildub:fix-crypto-sbom_package

Conversation

@gildub

@gildub gildub commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Nodes other than packages may carry a PURL and generate (provides) a crypto asset, e.g. a CycloneDX machine-learning model. Those have no sbom_package row, yet were returned by the crypto filter of the PURL listing, and counted in the packages_count of crypto algorithms.

Require the left node of the Generates relationship to have a matching sbom_package row in both places.

Summary by Sourcery

Ensure crypto relationships only treat actual SBOM packages as generating crypto assets.

Bug Fixes:

  • Restrict crypto algorithm package counts and crypto-filtered PURL results to nodes backed by an sbom_package record, excluding non-package nodes such as machine-learning models.

Tests:

  • Add coverage confirming non-package nodes that provide crypto assets are excluded from package counts and crypto-filtered PURL results.

Nodes other than packages may carry a PURL and generate (`provides`) a
crypto asset, e.g. a CycloneDX machine-learning model. Those have no
`sbom_package` row, yet were returned by the `crypto` filter of the PURL
listing, and counted in the `packages_count` of crypto algorithms.

Require the left node of the `Generates` relationship to have a matching
`sbom_package` row in both places.
@sourcery-ai

sourcery-ai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Implementation

Require a matching sbom_package row for the generating node in both the crypto algorithm package count and the PURL crypto filter.

  • modules/fundamental/src/crypto/service/mod.rs L30, L293-295, L322-331
  • modules/fundamental/src/purl/service/mod.rs L57-58, L777-779, L809-825

Tests

Add coverage showing that a non-package model which provides a crypto asset is excluded from package counts and PURL crypto-filter results.

  • modules/fundamental/src/crypto/endpoints/test.rs L524-566
  • modules/fundamental/src/purl/endpoints/test.rs L4668-4669, L4699-4712, L4725-4726

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@gildub
gildub added this pull request to the merge queue Nov 19, 2026
Merged via the queue into guacsec:main with commit 10c984b Nov 19, 2026
12 checks passed
@gildub
gildub deleted the fix-crypto-sbom_package branch November 19, 2026 13:42
@github-project-automation github-project-automation Bot moved this to Done in Trustify Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant