Skip to content

Fix temp file race on Windows and show failures logs in CI #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbybell merged 3 commits into from
Oct 18, 2026
Merged

Fix temp file race on Windows and show failures logs in CI #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f79e804
Fix temporary file name race on Windows
Rodrigodd Oct 17, 2026
ff018a1
Show test failure output on CI
Rodrigodd Oct 17, 2026
0cba001
Merge branch 'main' into upstream/windows-tmpfile-race
tbybell Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ jobs:
- name: Build library
run: meson compile -C build/
- name: Run tests
run: meson test -C build/
run: meson test -C build/ --print-errorlogs
- name: Upload test logs
if: failure()
uses: actions/upload-artifact@v4
with:
name: meson-logs-linux
path: build/meson-logs/

build-macos:
name: Build (macOS)
Expand All @@ -39,7 +45,13 @@ jobs:
- name: Build library
run: meson compile -C build/
- name: Run tests
run: meson test -C build/
run: meson test -C build/ --print-errorlogs
- name: Upload test logs
if: failure()
uses: actions/upload-artifact@v4
with:
name: meson-logs-macos
path: build/meson-logs/

build-windows:
name: Build (Windows MINGW64)
Expand All @@ -64,4 +76,10 @@ jobs:
- name: Build library
run: meson compile -C build/
- name: Run tests
run: meson test -C build/
run: meson test -C build/ --print-errorlogs
- name: Upload test logs
if: failure()
uses: actions/upload-artifact@v4
with:
name: meson-logs-windows
path: build/meson-logs/
2 changes: 1 addition & 1 deletion src/fstapi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ static FILE *tmpfile_open(char **nam)

if (fname) {
*nam = fname;
fh = unlink_fopen(fname, "w+b");
fh = fopen(fname, "w+b");
}
}

Expand Down
Loading