Repository navigation
Bump apple-private-apis: anisette failures are errors, not panics - #6
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NST6obdhaBcFjXHUjSLE2V
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NST6obdhaBcFjXHUjSLE2V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
apple-private-apisto gregakespret/apple-private-apis#2 (380f8ec).With that change,
omnisettereturns anisette-server failures as errors instead of panicking. Before, an unrecognisedGetHeadersErrorpanicked, and so did any non-provisioning error inget_anisette_headers, such as an HTML error page or a dropped connection. The panic killed the caller's task and the error message was lost. A non-JSON reply now reports its HTTP status and the start of its body. A badadi_pbis an error rather than a panic. A provisioning socket that closes mid-handshake no longer loops forever.cargo check --locked --lib --no-default-features --features remote-anisette-v3passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01NST6obdhaBcFjXHUjSLE2V