Repository navigation
Conversation
A nullable variable on a non-null argument is allowed when that argument has a default. Usages recorded from a fragment dropped the default, so the same query was rejected only in the fragment form.
|
@SashaMIT is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A nullable variable used on a non-null argument is allowed when that argument has a default. Variable usages inside a fragment were recorded with no location default, so
url(height: $h)inside a fragment was rejected while the same field inline was accepted.The fragment usage now keeps the argument default from
typeInfo.getDefaultValue(). An argument without a default is still rejected. A variable default of null is still rejected.Test plan
npm run node:test -- src/validation/__tests__/VariablesInAllowedPositionRule-test.ts(38 passed)Variable "$intVar" of type "Int" used in position expecting type "Int!".Int => Int! within fragmentstill reports that error when the argument has no default.eslintandprettier --checkpassed on the two files.Fixes #4864