Skip to content

Why is DatabaseService needed? #15

Open

Description

@Nyholm

Why is the GraphAware\Reco4PHP\Persistence\DatabaseService needed? (source)

It works as a wrapper for the ClientBuilder. Wouldn't it be simpler to typehint for a ClientInterace directly. That would remove an unneeded abstraction layer.

Activity

  1. ikwattro commented on Feb 20, 2017

    @ikwattro
    Member

    The initial idea was to make it compatible with other graph dbs in the future, but I completely forgot this idea. So yes it makes sense to just have a typhint on ClientInterface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions