Repository navigation
test(magento): the table queue contention is deterministic (#731) - #1042
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
twoWorkersNeverTakeTheSameMessagefailed in themagento-bootjob on Mage-OS 2.2.0 / PHP 8.2 (run 37977359579): one worker finished its 60 messages before the other had started, somin($counts)was 0. The two worker processes now connect, then wait on a barrier directory until both are ready, and only then start taking. The assertions are unchanged: 60 ids, 60 distinct, and the minimum count above 0.The
drainmode ofFixture/worker.phptakes an optional barrier directory and a worker count. A worker that does not see its peer within 60 seconds exits with 1.Checked
The files pass
php-cs-fixerandphp -l. The test itself needs a Magento install and MySQL 8.4, so it skipped here (6 of 6 skipped): it has not run on my machine. The pull request's CI is the check.Not in this pull request
The barrier makes a one-sided drain very unlikely, not impossible: each message costs at least 5 ms, so a worker needs 300 ms of lead over its peer to finish alone. If the job still flakes, the next step is to hold the row lock of the first message in the test's own connection so
SKIP LOCKEDmust skip it.Refs #731 #738