Repository navigation
docs(magento): describe the database backend where Magento was memory or Temporal only (#739, #1036) - #1041
Open
gplanchat wants to merge 3 commits into
Open
docs(magento): describe the database backend where Magento was memory or Temporal only (#739, #1036)#1041gplanchat wants to merge 3 commits into
gplanchat wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Magento passages that still described two backends now describe three: the database backend that
resource/durableselects, Temporal whendurable/temporal/dsnis set, and the in-process journal otherwise. Declaring both throwsBackendSelectionException.resource/durableanddb/connection/durableentries anddurable:setup([Task] Magento on a database: change the public promise (picker, backends and configuration pages, UPGRADE) #739).run-not-progressing(EN and FR): a section for the database backend, and the pickup time the grid shows there ([Task] Update the pages that still describe Magento as memory or Temporal only #1036).README.mdandsrc/DurableModule/README.md: "memory and Temporal only" is gone.UPGRADE.md: a "Changed" section at the end of "Unreleased" ([Task] Magento on a database: change the public promise (picker, backends and configuration pages, UPGRADE) #739). The module README now points to the database backend where it said Magento would not get a journal of its own.#842 is already satisfied on main (the re-audit comment on the ticket lists each box), so I changed nothing for it.
Checked
RuntimeFactory::backend(),JournalConnectionResolver,MagentoWorkflowRunCatalog(picked_up_atfillswaitingForWorkerSince) andHealthCommand.hugo --minifybuilds.git grep "only two of the four"returns nothing in EN and FR.Not in this pull request
ALLOWED.magento,WHYNOT.magento,FWNOTE.magentoinindex.htmlandindex.fr.html): [Task] Magento on a database: change the public promise (picker, backends and configuration pages, UPGRADE) #739 leaves the key of the new SQL row to you. Which key?RuntimeFactory("Magento reaches no other persistent journal"), outside the documentation.durable:healthstill prints the "No Temporal DSN" message on the database backend; the pages say thatdurable:healthonly checks that the journal database answers, and that the grid shows a run that waits for a worker.Refs #739, #1036