Repository navigation
refactor(core): the static journal readers accept an ExecutionId (#682) - #1040
Merged
Merged
Conversation
gplanchat
added a commit
that referenced
this pull request
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
First slice of #682. The 13 interfaces and
Event::executionId()already take or return anExecutionIdon main. What is left is the helpers whose signature #638 kept onstring. This slice takes the three static journal readers:ActivityEventJournal(6 methods, the ticket says 5)WorkflowQueryEvaluator::lastExecutionResult()andhasPendingTimer()ParentChildWorkflowCoordinator::isChildRunActive()Each parameter widens from
stringtoExecutionId|string, with the same name. This is the step the engine and the history source took in 5744c7a: no call breaks, so there is no Rector rule or UPGRADE entry yet.AwaitedFact::isJournalledIn(),ChildWorkflowRunnerandParentChildWorkflowCoordinator::onParentClosed()pass theExecutionIdthey hold instead of converting it to a string and back. Wire callers (ActivityMessageProcessor,TemporalActivityWorker) still pass the message string.Checked
TheJournalHelpersAcceptAnExecutionIdTestfails with aTypeErroron the old signatures and passes now.Not in this pull request
ExecutionIdonly. It is breaking and needs a Rector rule:ExecutionIdArgumentRectormatches method calls only, so it must learn static calls first, and an UPGRADE entry at the end of "Unreleased".RunDashboard::run(),JournalRunHistoryReader,DurableDataCollector,DiagnoseExecutionCommand,DurableBundleTestTrait,ProcessDetail::getRun(),DurableTestCase,JournalAssertions,WorkflowClient::startCron()andpollForCompletion().WorkflowRunDescription::$executionId: the ticket allows either anExecutionIdor an ADR that keeps the string, and does not choose.Refs #682