Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
I add one step to
magento-boot, after Psalm: it creates adurable_testdatabase on the job's MySQL 8.4 service, grants it to themagentouser, and runsvendor/bin/phpunit -c phpunit.magento.xml --display-skipped --fail-on-skippedwithDURABLE_TEST_MYSQL=magento:magento@127.0.0.1:3306/durable_test.The suites under
tests/integration/DurableModule(resume lock, table queue, run projection) skip themselves unlessmagento/vendorexists andDURABLE_TEST_MYSQLnames a server. No job set both, so merged code was never exercised.magento-boothas the Magento install (magento/vendor) and the rootvendor/(PHPUnit), and I give the tests a database of their own so they cannot touch the shop's tables.ci-okalready needsmagento-boot, so its list does not change.This does not close #738: the issue also asks for a second MySQL declared as
db/connection/durable,durable:setup, the conformance harness undermagento/and the restart experiment. Those stay open.Checked
magento-boot.posixis available in the setup-php build (the lock tests kill a process), and themagentouser may be granted a database by root.