Repository navigation
fix(Insets): remove manual status bar insets workaround and rely on native SDK WindowInsets support - #97
Draft
LoyalAbbas wants to merge 1 commit into
Draft
fix(Insets): remove manual status bar insets workaround and rely on native SDK WindowInsets support#97LoyalAbbas wants to merge 1 commit into
LoyalAbbas wants to merge 1 commit into
Conversation
…ative SDK WindowInsets support
LoyalAbbas
requested review from
dkhawk and
kikoso
and removed request for
dkhawk
November 6, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the temporary client-side status bar inset and system-bar hiding workarounds introduced while waiting for native
WindowInsetssupport in the Maps 3D SDK (tracked in https://issuetracker.google.com/issues/575850758), and fixes initial placement of the Quick Settings button onUiControlsActivity.What Changed
Map3DSettings.applyStatusBarInsetsToMapView):ids.xml), and the temporary workaround test suite (Map3DStatusBarInsetsTest.kt).ViewCompat.requestApplyInsets(...)dispatch inSampleBaseActivity(Kotlin & Java),UiControlsActivity(Kotlin, Java, Compose),Map3DQuickSettingsButton,Map3DQuickSettingsWidget, andmaps3d-compose(GoogleMap3D).WindowInsetsCompatfromSampleBaseActivity's inset listener so siblingMap3DViewinstances receive system bar and display cutout insets natively.Utilities.enableImmersiveMode()to keep system bars visible (insetsController.show(WindowInsetsCompat.Type.systemBars())) under standard edge-to-edge rendering.UiControlsActivity:uiControlsOverridesupport toMap3DQuickSettingsButton(matchingMap3DQuickSettingsWidgetin Compose) so asynchronous window-inset passes andattachMap()refreshes preserve screen-level UI control overrides.updateTopMarginForUiControls(buildCurrentUiControls())duringonCreatein both Kotlin and JavaUiControlsActivityso the Quick Settings FAB clears the active trailing controls from the first frame.Verification
./gradlew spotlessCheckpasses across all modules.:Maps3DSamples:ApiDemos:kotlin-app:assembleDebug,:Maps3DSamples:ApiDemos:java-app:assembleDebug,:Maps3DSamples:ComposeDemos:app:assembleDebug, and:Maps3DSamples:ApiDemos:common:testDebugUnitTest.