impl(bigtable): test grpc otel plugin configuration - #16347
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the gRPC metrics exporter by extracting the configuration logic of the OpenTelemetry plugin into a new GrpcMetricsPluginConfig struct and helper functions (MakeGrpcMetricsPluginConfig). It also adds corresponding unit tests to validate the configuration arguments. The feedback suggests passing the opentelemetry::sdk::resource::Resource object by value instead of by const reference in MakeGrpcMetricsPluginConfig to avoid unnecessary copies and allow moving it into the lambda function.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16347 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 2227 2227
Lines 209543 209594 +51
=======================================
+ Hits 193284 193337 +53
+ Misses 16259 16257 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This PR factors out the configuration into a separate function that we can more easily test.