Repository navigation
fix(go): use correct flag for skipped aliases - #634
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request renames the command-line flag excluded-aliases to skipped-aliases in sdk/go/garf/cmd/run.go. Feedback suggests improving the robustness of parsing comma-separated aliases by trimming surrounding whitespace and ignoring empty elements when splitting the input string.
Comment on lines
+44
to
46
| if skippedAliases != "" { | ||
| options.SkippedAliases = strings.Split(skippedAliases, ",") | ||
| } |
There was a problem hiding this comment.
When parsing comma-separated command-line flags, users often include spaces around the commas (e.g., --skipped-aliases "alias1, alias2"). Directly splitting by "," without trimming whitespace will result in elements with leading or trailing spaces (e.g., " alias2"), which can cause matching logic to fail. Trimming spaces and ignoring empty elements ensures more robust input parsing.
if skippedAliases != "" {
for _, s := range strings.Split(skippedAliases, ",") {
if trimmed := strings.TrimSpace(s); trimmed != "" {
options.SkippedAliases = append(options.SkippedAliases, trimmed)
}
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.