guard non-positive requested_digits in DigitGenCounted - #313
Merged
Conversation
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASan (Release build),
FastDtoa(1234567.0, FAST_DTOA_PRECISION, 0, ...)into a one-byte buffer:DigitGenCounted's integral loop decrementsrequested_digitsand only breaks on an exact0, so a call with0(the first decrement makes it-1) never stops and emits every digit of the value past the end of the buffer; a negative count behaves the same way.DoubleToAsciispecial-cases PRECISION with0digits before it ever reaches here, and #306 added the matching guard to the Bignum slow path inGenerateCountedDigits, but the Grisu3 fast path, reachable through the installedFastDtoaAPI, was still unguarded.Fix returns
falsewith length0whenrequested_digits <= 0, before the loop runs, so nothing is written. Valid precision requests are unchanged. The regression test fences a one-byte buffer with a sentinel and checks it survives; the full ctest suite passes in Debug and Release.