Remove the BitSize helper template to fix -Wunused-template with clang 23 - #312
Merged
Merged
Conversation
…g 23 BitSize was only used inside DOUBLE_CONVERSION_ASSERT, so in builds where the assertion compiles to nothing it is an internal-linkage function template with no instantiations. clang 23.1.0 diagnoses that under -Wall (-Wunused-template), which breaks -Werror builds. Inline the trivial computation instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BitSizeinbignum.ccis only used insideDOUBLE_CONVERSION_ASSERT, so in builds where the assertion compiles to nothing it is an internal-linkage function template with no instantiations. clang 23.1.0 diagnoses that under-Wall:which breaks
-Werrorbuilds (seen building Firefox, which vendors double-conversion). The helper computes8 * sizeof(value), so inline that into the single assertion and drop the template. Same spirit as #56 forMin/Max.