Skip to content

feat: Set CAPTURE_MESSAGE_CONTENT_IN_SPANS default to false - #1144

Open
r4inee wants to merge 1 commit into
google:mainfrom
r4inee:feature/default-message-content-in-tracing-to-false
Open

r4inee wants to merge 1 commit into
google:mainfrom
r4inee:feature/default-message-content-in-tracing-to-false

Conversation

@r4inee

@r4inee r4inee commented Apr 15, 2026 •

Copy link
Copy Markdown
Contributor

Link to Issue or Description of Change

Problem:
LLM request/response content and tool arguments/responses will no longer be captured in OpenTelemetry spans unless explicitly opted in.

ADK should provide a privacy-first default to avoid UGC being accidently extracted, aligning with OTEL conventions.

Solution:
Tracing.java — The default value of the ADK_CAPTURE_MESSAGE_CONTENT_IN_SPANS environment variable should default from true → false.

Note that this will diverge from the adk-python behaviour, but IMO for the better.

https://github.com/google/adk-python/blame/b8e8f6b90290e48e134f48bbe7e2b800276e7269/src/google/adk/telemetry/tracing.py#L484

@r4inee
r4inee force-pushed the feature/default-message-content-in-tracing-to-false branch from c8b011b to c25bf3a Compare May 11, 2026 01:17
@r4inee
r4inee force-pushed the feature/default-message-content-in-tracing-to-false branch from c25bf3a to 31edc5d Compare June 16, 2026 12:36
@r4inee r4inee mentioned this pull request Jun 24, 2026
10 tasks done
@r4inee
r4inee force-pushed the feature/default-message-content-in-tracing-to-false branch from 31edc5d to feec0d6 Compare June 24, 2026 08:30
@hemasekhar-p hemasekhar-p self-assigned this Jul 16, 2026
@hemasekhar-p

Copy link
Copy Markdown
Contributor

@r4inee, thank you for your contribution! We appreciate you taking the time to submit this pull request. Currently this PR is under review by our team, we will keep you posted if any additional information is required. thank you.

@damianmomotgoogle

Copy link
Copy Markdown
Contributor

Hi!

This repo requires commit message to be aligned with conventional commits.

Can you mark it as "feat:" ?

@damianmomotgoogle damianmomotgoogle added waiting on reporter Waiting for reaction by reporter. Failing that, maintainers will eventually closed it as stale. and removed needs review labels Oct 15, 2026
@r4inee
r4inee force-pushed the feature/default-message-content-in-tracing-to-false branch from feec0d6 to 81a6a04 Compare October 17, 2026 12:14
@r4inee r4inee changed the title Set CAPTURE_MESSAGE_CONTENT_IN_SPANS default to false feat: Set CAPTURE_MESSAGE_CONTENT_IN_SPANS default to false Oct 17, 2026
@r4inee

r4inee commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Hi @damianmomotgoogle, have updated the PR and commit

@hemasekhar-p hemasekhar-p added needs review and removed waiting on reporter Waiting for reaction by reporter. Failing that, maintainers will eventually closed it as stale. labels Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Telemetry: Default message content capture to false

3 participants