Repository navigation
Conversation
r4inee
force-pushed
the
feature/default-message-content-in-tracing-to-false
branch
from
May 11, 2026 01:17
c8b011b to
c25bf3a
Compare
r4inee
force-pushed
the
feature/default-message-content-in-tracing-to-false
branch
from
June 16, 2026 12:36
c25bf3a to
31edc5d
Compare
10 tasks done
r4inee
force-pushed
the
feature/default-message-content-in-tracing-to-false
branch
from
June 24, 2026 08:30
31edc5d to
feec0d6
Compare
Contributor
|
@r4inee, thank you for your contribution! We appreciate you taking the time to submit this pull request. Currently this PR is under review by our team, we will keep you posted if any additional information is required. thank you. |
Contributor
|
Hi! This repo requires commit message to be aligned with conventional commits. Can you mark it as "feat:" ? |
r4inee
force-pushed
the
feature/default-message-content-in-tracing-to-false
branch
from
October 17, 2026 12:14
feec0d6 to
81a6a04
Compare
Contributor
Author
|
Hi @damianmomotgoogle, have updated the PR and commit |
damianmomotgoogle
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Problem:
LLM request/response content and tool arguments/responses will no longer be captured in OpenTelemetry spans unless explicitly opted in.
ADK should provide a privacy-first default to avoid UGC being accidently extracted, aligning with OTEL conventions.
Solution:
Tracing.java — The default value of the ADK_CAPTURE_MESSAGE_CONTENT_IN_SPANS environment variable should default from true → false.
Note that this will diverge from the
adk-pythonbehaviour, but IMO for the better.https://github.com/google/adk-python/blame/b8e8f6b90290e48e134f48bbe7e2b800276e7269/src/google/adk/telemetry/tracing.py#L484