pdfkit: add Page.AddLink for clickable /Link URI annotations - #21
Merged
Conversation
A generated PDF could draw a hyperref link's text but not make it navigable — there was no annotation API — so \href/\url rendered as plain text in the PDF while the SVG output already carried a live <a href>. Add Page.AddLink(rect, uri): it records a borderless clickable rectangle whose /A is a URI action, and Write emits one /Link annotation per link in the page's /Annots array (/Rect is [llx lly urx ury] in default user space, matching the coordinates the drawing methods use). A page with no links emits no /Annots. Tests cover the emitted /Annots //Link //URI structure and paren escaping in the URL, plus the no-links path; 100% coverage, go vet and gofmt clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A generated PDF could draw a hyperref link's text but not make it navigable — there was no annotation API — so
\href/\urlrendered as plain text in the PDF even though the SVG output already carried a live<a href>.How
Page.AddLink(rect Rect, uri string)records a borderless clickable rectangle whose/Ais a URI action;Writeemits one/Linkannotation per link in the page's/Annotsarray./Rectis[llx lly urx ury]in the page's default user space — the same coordinates the drawing methods use — and a page with no links emits no/Annots.Verification
Tests cover the emitted
/Annots·/Link·/URIstructure and paren escaping in the URL, plus the no-links path. 100% coverage,go vet,gofmtclean.Enables clickable PDF links in go-tex/engine (a follow-up wires the engine's PDF driver's
linknode to this API).🤖 Generated with Claude Code