ARC: shard the weak-reference table - #401
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
Member
|
This looks more invasive than it should be. The original refactoring to make the type used for a weak ref table distinct was intended to make it easy to provide a replacement that did the sharding internally. |
DTW-Thalion
force-pushed
the
arc-weak-table-sharding
branch
from
July 24, 2026 13:01
ff83926 to
79eb446
Compare
DTW-Thalion
marked this pull request as ready for review
July 28, 2026 01:27
DTW-Thalion
force-pushed
the
arc-weak-table-sharding
branch
from
July 28, 2026 03:23
79eb446 to
ddc3ebc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weak-reference table took a single global lock, so weak operations on unrelated objects serialised on one mutex and scaled negatively with core count.
The striping now lives inside the table type rather than at its call sites: WeakRefTable holds an array of independently locked stripes, picks one from the object address, and keeps the operations it offered before, so nothing outside it knows the table is striped at all. The stripe count is a build flag or the OBJC_WEAK_SHARD_COUNT environment variable.
Three things the striping needed in its own right: the stripe a block belongs to is fixed when the block is created, which closes a lock-selection race that showed up as a use-after-free under AddressSanitizer with more than one stripe; a block's weak slot is accessed atomically, so the striping also holds on weakly ordered targets, checked under ThreadSanitizer; and a block is recycled within its own stripe.
#399 has merged, so the diff here is this change alone.