Skip to content

Allow Triggers as a top-level SDK namespace #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashish-kumar2-glean merged 1 commit into from
Aug 19, 2026
+7 −1
Merged

Allow Triggers as a top-level SDK namespace #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/post_transform_smoke.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,13 @@ describe('Post-transformation smoke tests', () => {
// without a group silently falls back to its `tags` and leaks a method to
// the SDK top level. The top level is reserved for the Platform API, so
// client/indexing operations must be nested under `client.*` / `indexing.*`.
const platformSegments = new Set(['agents', 'chat', 'search', 'skills']);
const platformSegments = new Set([
'agents',
'chat',
'search',
'skills',
'triggers',
]);
const allowedTopLevelSegments = new Set([
'client',
'indexing',
Expand Down
Loading